From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbcAEMXI (ORCPT ); Tue, 5 Jan 2016 07:23:08 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:47771 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbcAEMXF (ORCPT ); Tue, 5 Jan 2016 07:23:05 -0500 Date: Tue, 5 Jan 2016 12:22:40 +0000 From: One Thousand Gnomes To: Pan Xinhui Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , mnipxh@163.com, yanmin_zhang@linux.intel.com Subject: Re: [PATCH V2] tty/n_gsm.c: use gsm->num to remove mux itself from gsm_mux[] Message-ID: <20160105122240.5e4ee037@lxorguk.ukuu.org.uk> In-Reply-To: <568B73FC.7020407@linux.vnet.ibm.com> References: <568B73FC.7020407@linux.vnet.ibm.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 05 Jan 2016 15:42:52 +0800 Pan Xinhui wrote: > From: Pan Xinhui > > There is one filed gsm->num to store mux's index of gsm_mux[]. So use > gsm->num to remove itself from gsm_mux[] instead of the for-loop > traverse in gsm_cleanup_mux(). > > Signed-off-by: Pan Xinhui Reviewed-by: Alan Cox