From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752410AbcAEWft (ORCPT ); Tue, 5 Jan 2016 17:35:49 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42230 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbcAEWfr (ORCPT ); Tue, 5 Jan 2016 17:35:47 -0500 Date: Tue, 5 Jan 2016 14:35:46 -0800 From: Andrew Morton To: chengang@emindsoft.com.cn Cc: will.deacon@arm.com, tangchen@cn.fujitsu.com, kuleshovmail@gmail.com, tony.luck@intel.com, vladimir.murzin@arm.com, baiyaowei@cmss.chinamobile.com, holt@sgi.com, ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org, Chen Gang Subject: Re: [PATCH] include/linux/memblock.h: Use __init_memblock for movable_node_is_enabled Message-Id: <20160105143546.7b3aa50adbac72daf8c09540@linux-foundation.org> In-Reply-To: <1452032756-10196-1-git-send-email-chengang@emindsoft.com.cn> References: <1452032756-10196-1-git-send-email-chengang@emindsoft.com.cn> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Jan 2016 06:25:56 +0800 chengang@emindsoft.com.cn wrote: > The related warning: > > LD mm/built-in.o > WARNING: mm/built-in.o(.text.unlikely+0x155d): Section mismatch in reference from the function movable_node_is_enabled() to the variable .meminit.data:movable_node_enabled > The function movable_node_is_enabled() references > the variable __meminitdata movable_node_enabled. > This is often because movable_node_is_enabled lacks a __meminitdata > annotation or the annotation of movable_node_enabled is wrong. Thanks. Kirill just sent (almost) the same patch: From: "Kirill A. Shutemov" Subject: memblock: fix section mismatch allmodconfig produces following warning for me: WARNING: vmlinux.o(.text.unlikely+0x10314): Section mismatch in reference from the function movable_node_is_enabled() to the variable .meminit.data:movable_node_enabled The function movable_node_is_enabled() references the variable __meminitdata movable_node_enabled. This is often because movable_node_is_enabled lacks a __meminitdata annotation or the annotation of movable_node_enabled is wrong. Let's mark the function with __meminit. It fixes the warning. Signed-off-by: Kirill A. Shutemov Signed-off-by: Andrew Morton --- include/linux/memblock.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff -puN include/linux/memblock.h~memblock-fix-section-mismatch include/linux/memblock.h --- a/include/linux/memblock.h~memblock-fix-section-mismatch +++ a/include/linux/memblock.h @@ -60,6 +60,14 @@ extern int memblock_debug; extern bool movable_node_enabled; #endif /* CONFIG_MOVABLE_NODE */ +#ifdef CONFIG_ARCH_DISCARD_MEMBLOCK +#define __init_memblock __meminit +#define __initdata_memblock __meminitdata +#else +#define __init_memblock +#define __initdata_memblock +#endif + #define memblock_dbg(fmt, ...) \ if (memblock_debug) printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) @@ -164,7 +172,7 @@ static inline bool memblock_is_hotplugga return m->flags & MEMBLOCK_HOTPLUG; } -static inline bool movable_node_is_enabled(void) +static inline bool __init_memblock movable_node_is_enabled(void) { return movable_node_enabled; } @@ -397,14 +405,6 @@ static inline unsigned long memblock_reg for (idx = 0; idx < memblock_type->cnt; \ idx++,rgn = &memblock_type->regions[idx]) -#ifdef CONFIG_ARCH_DISCARD_MEMBLOCK -#define __init_memblock __meminit -#define __initdata_memblock __meminitdata -#else -#define __init_memblock -#define __initdata_memblock -#endif - #ifdef CONFIG_MEMTEST extern void early_memtest(phys_addr_t start, phys_addr_t end); #else _