From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521AbcAEOhP (ORCPT ); Tue, 5 Jan 2016 09:37:15 -0500 Received: from mx2.suse.de ([195.135.220.15]:37514 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbcAEOhK (ORCPT ); Tue, 5 Jan 2016 09:37:10 -0500 Date: Tue, 5 Jan 2016 15:37:17 +0100 From: Jan Kara To: Sergey Senozhatsky Cc: Jan Kara , Sergey Senozhatsky , Andrew Morton , Petr Mladek , KY Sri nivasan , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] printk: Hand over printing to console if printing too long Message-ID: <20160105143717.GC14464@quack.suse.cz> References: <20151210145251.GA540@swordfish> <20151222134730.GD7266@quack.suse.cz> <20151223015420.GA2008@swordfish> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151223015420.GA2008@swordfish> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed 23-12-15 10:54:49, Sergey Senozhatsky wrote: > slowly looking through the patches. Back from Christmas vacation... > How about setting 'sync_print' to 'true' in... > bust_spinlocks() /* only set to true */ > or > console_verbose() /* um... may be... */ > or > having a separate one-liner for that > > void console_panic_mode(void) > { > sync_print = true; > } > > and call it early in panic(), before we send out IPI_STOP. I like using console_verbose() for setting sync_print to true. That will likely be more reliable than using oops in progress. After all console_verbose() is used like console_panic_mode() anyway and in quite a few places so it is a reasonable match. Honza -- Jan Kara SUSE Labs, CR