From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752459AbcAEPr3 (ORCPT ); Tue, 5 Jan 2016 10:47:29 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36880 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbcAEPrY (ORCPT ); Tue, 5 Jan 2016 10:47:24 -0500 Date: Tue, 5 Jan 2016 15:47:19 +0000 From: Mark Brown To: Chen Feng Cc: lee.jones@linaro.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, yudongbin@hisilicon.com, saberlily.xia@hisilicon.com, suzhuangluan@hisilicon.com, kong.kongxinwei@hisilicon.com, xuyiping@hisilicon.com, z.liuxinliang@hisilicon.com, puck.chenfeng@gmail.com, weidong2@hisilicon.com, w.f@huawei.com, qijiwen@hisilicon.com, peter.panshilin@hisilicon.com, dan.zhao@hisilicon.com, linuxarm@huawei.com, liguozhu@hisilicon.com, shimingxing@hisilicon.com, albert.lubing@hisilicon.com, oliver.fu@hisilicon.com, haojian.zhuang@linaro.org Message-ID: <20160105154719.GC6588@sirena.org.uk> References: <1451910472-126417-1-git-send-email-puck.chen@hisilicon.com> <1451910472-126417-3-git-send-email-puck.chen@hisilicon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NU0Ex4SbNnrxsi6C" Content-Disposition: inline In-Reply-To: <1451910472-126417-3-git-send-email-puck.chen@hisilicon.com> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 2/5] doc: bindings: Document for hi655x regulator driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NU0Ex4SbNnrxsi6C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 04, 2016 at 08:27:49PM +0800, Chen Feng wrote: > Add Document for hi655x pmic regulator driver As indicated in the driver review this seems to be a bit of an unusual binding that I think needs reworking, also it needs a bit more detail - for example, listing which regulator names are valid. Please also use subject lines reflecting the normal style for the subsystem. --NU0Ex4SbNnrxsi6C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWi+WGAAoJECTWi3JdVIfQ7BQH/ReA7lqEQLd/ZDBzOGC20SIL 2n6gRbM2K1z8rUzzBrF6gTkjL48y7zdpbsT1L9qLVQVq2szQ0hH1Q+AmlpZt/iOu EVn5ka7HRw/rp+a82ry4BqtihuD4Dqy+5jJ+3Wf/ae0eVcPcTCOqTLHKRJwXiCx2 yr9p9GbQoyTEHhgKBrKXDNxGnIYh96QwGrHXWFepjaBI2rCfJcptb/wQzyqCFNZo r7id7S65ykg9uSFCFP6lzix3NKGeOkpPJKHENaaosE1j7fwUj+7pE7gOjuToNOrc UHlZClfhPvAmrS0KyKWhDXROBdUvvANgLkdJMz0UIkGLKCo7zoheL6W3UtWjlPA= =Gxfl -----END PGP SIGNATURE----- --NU0Ex4SbNnrxsi6C--