mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>, G@thunk.org
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Greg KH <gregkh@linuxfoundation.org>,
	Pierre Paul MINGOT <mingot.pierre@gmail.com>,
	jslaby@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add possibility to set /dev/tty number
Date: Tue, 5 Jan 2016 11:11:45 -0500	[thread overview]
Message-ID: <20160105161145.GA7138@thunk.org> (raw)
In-Reply-To: <568BC244.5040207@gmail.com>

On Tue, Jan 05, 2016 at 08:16:52AM -0500, Austin S. Hemmelgarn wrote:
> >We don't do regressions.
> Requiring only a recompilation isn't a regression, especially when it works
> fine without being recompiled, and I have yet to actually see anything that
> changing the number of VT's would break other than ConsoleKit
> (systemd-logind might also need a rebuild, but I'm not sure about that, and
> don't have a system I could test it on).

Sorry, breaking a compiled binary is a regression.

People have outlined more clever ways of trying to accomplish your
goal (saving memory) without breaking other people.  I suggest you
give that a try instead of just trying to defend your existing patch.

       		  	   	     - Ted

  parent reply	other threads:[~2016-01-05 16:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 15:34 Pierre Paul MINGOT
2016-01-04 15:43 ` Greg KH
2016-01-04 16:57   ` Austin S. Hemmelgarn
2016-01-04 17:11     ` Greg KH
2016-01-04 18:41       ` Austin S. Hemmelgarn
2016-01-04 22:55         ` One Thousand Gnomes
2016-01-05 13:16           ` Austin S. Hemmelgarn
2016-01-05 15:24             ` Greg KH
2016-01-05 15:33               ` Austin S. Hemmelgarn
2016-01-05 16:11             ` Theodore Ts'o [this message]
2016-01-05 16:22               ` Austin S. Hemmelgarn
2016-01-05  8:51         ` Pierre Paul MINGOT
2016-01-05 13:02           ` Austin S. Hemmelgarn
2016-01-05 15:25           ` Greg KH
2016-01-05 15:43             ` Austin S. Hemmelgarn
2016-01-05 16:03               ` Greg KH
2016-01-05 18:38         ` Austin S. Hemmelgarn
2016-01-05 20:47           ` One Thousand Gnomes
2016-01-06 12:42             ` Austin S. Hemmelgarn
2016-01-06 13:54               ` One Thousand Gnomes
2016-01-06 14:07                 ` Austin S. Hemmelgarn
2016-01-06 13:39 ` Austin S. Hemmelgarn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160105161145.GA7138@thunk.org \
    --to=tytso@mit.edu \
    --cc=G@thunk.org \
    --cc=ahferroin7@gmail.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingot.pierre@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome