From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751636AbcAEROI (ORCPT ); Tue, 5 Jan 2016 12:14:08 -0500 Received: from mx2.suse.de ([195.135.220.15]:48014 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521AbcAEROE (ORCPT ); Tue, 5 Jan 2016 12:14:04 -0500 Date: Tue, 5 Jan 2016 18:14:12 +0100 From: Jan Kara To: Toralf =?iso-8859-1?Q?F=F6rster?= Cc: linux-security-module@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ext4: use XATTR_*_PREFIX_LEN instead sizeof(...) Message-ID: <20160105171412.GD18604@quack.suse.cz> References: <1451850998-28639-1-git-send-email-toralf.foerster@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1451850998-28639-1-git-send-email-toralf.foerster@gmx.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 03-01-16 20:56:37, Toralf Förster wrote: > use the definition in include/uapi/linux/xattr.h > > Signed-off-by: Toralf Förster Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/xattr_security.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/xattr_security.c b/fs/ext4/xattr_security.c > index 36f4c1a..1a3d629 100644 > --- a/fs/ext4/xattr_security.c > +++ b/fs/ext4/xattr_security.c > @@ -16,7 +16,7 @@ ext4_xattr_security_list(const struct xattr_handler *handler, > struct dentry *dentry, char *list, size_t list_size, > const char *name, size_t name_len) > { > - const size_t prefix_len = sizeof(XATTR_SECURITY_PREFIX)-1; > + const size_t prefix_len = XATTR_SECURITY_PREFIX_LEN; > const size_t total_len = prefix_len + name_len + 1; > > > -- > 2.4.10 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara SUSE Labs, CR