From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbcAERlZ (ORCPT ); Tue, 5 Jan 2016 12:41:25 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:37005 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751666AbcAERlX (ORCPT ); Tue, 5 Jan 2016 12:41:23 -0500 Date: Tue, 5 Jan 2016 17:41:14 +0000 From: Mark Brown To: Laxman Dewangan Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, swarren@wwwdotorg.org Message-ID: <20160105174114.GI6588@sirena.org.uk> References: <1450788927-22116-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LYw3s/afESlflPpp" Content-Disposition: inline In-Reply-To: <1450788927-22116-1-git-send-email-ldewangan@nvidia.com> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LYw3s/afESlflPpp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 22, 2015 at 06:25:26PM +0530, Laxman Dewangan wrote: > + d->type_reg_stride = chip->type_reg_stride ? : 1; > + Please don't abuse the ternery operator, especially not the GCC extension - that's much less clear than just writing the if statement. --LYw3s/afESlflPpp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWjAA6AAoJECTWi3JdVIfQFHYH/0JYHQ989QS3AWl7OtusORlk 2WlfcoE2RIu1TA4aFDuEl5C562BVutq/3G0Yqt4AoqaRR+vdCT3aFgJO6iskf+5h yc09LEITxOdUf8ZvuUBTP1rBJoPLrOEHapU0NLypqELMZcKpSLixDPZehs2SN40R GlZi6ce2JNX9uPcOOX92TEZ+r8Oh8kTVMfecPH/61Vht5lZNjw4b0imZo5MkU0B0 ELlcBVXKkHKy5NZ80GfK8HAGaLK0Qes3sPOez5LSSiuNJ+ASTSW70jMtQYHyCl/7 MFIWVA8TJfpDUtvIuf5W9U21kVWfqlD+LkIK9f+VqJcWApy8eUijclZPhF//c6U= =+yDv -----END PGP SIGNATURE----- --LYw3s/afESlflPpp--