From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728AbcAFBxT (ORCPT ); Tue, 5 Jan 2016 20:53:19 -0500 Received: from smtprelay0097.hostedemail.com ([216.40.44.97]:35004 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752409AbcAFBxP (ORCPT ); Tue, 5 Jan 2016 20:53:15 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3165:3352:3622:3865:3867:3868:3871:3872:3873:3874:5007:6261:7875:8660:10010:10400:10848:10967:11026:11232:11658:11914:12043:12438:12517:12519:12740:13069:13148:13230:13311:13357:14096:14097:14659:21067:21080:30054:30064:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:1:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: car58_1bcada1037349 X-Filterd-Recvd-Size: 1943 Date: Tue, 5 Jan 2016 20:53:09 -0500 From: Steven Rostedt To: "Zhang, Yanmin" Cc: "Qiu, PeiyangX" , Ingo Molnar , Rusty Russell , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] module: deal with the failure of complete_formation Message-ID: <20160105205309.732a80af@gandalf.local.home> In-Reply-To: <568C727A.9050904@linux.intel.com> References: <567CE0A7.80605@intel.com> <567CEA31.1070507@intel.com> <20160105200114.59fbf832@gandalf.local.home> <568C6A82.6090202@linux.intel.com> <20160105202948.209acfb5@gandalf.local.home> <568C727A.9050904@linux.intel.com> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 06 Jan 2016 09:48:42 +0800 "Zhang, Yanmin" wrote: > On 2016/1/6 9:29, Steven Rostedt wrote: > > On Wed, 06 Jan 2016 09:14:42 +0800 > > "Zhang, Yanmin" wrote: > > > > > >> It's a good idea although ftrace_module_init_fail might be complicated. > > How so? I posted the patch. All it does is to call > > ftrace_release_mod(), which will only remove pages that are included > > with the module. If the pages were not added yet, nothing is done. > > You are right. ftrace_release_mod can be used. I was going to call that directly, but for clarity, documentation and robustness I added the new call. Hmm, but on second thought, I noticed that it is already shown globally. I think I'll change that back to call ftrace_release_mod() directly. -- Steve