From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbcAFGXb (ORCPT ); Wed, 6 Jan 2016 01:23:31 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:34029 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751601AbcAFGX3 (ORCPT ); Wed, 6 Jan 2016 01:23:29 -0500 Date: Wed, 06 Jan 2016 01:23:26 -0500 (EST) Message-Id: <20160106.012326.1058946039396006074.davem@davemloft.net> To: jarod@redhat.com Cc: linux-kernel@vger.kernel.org, eugene.shatokhin@rosalab.ru, prudy1@o2.pl, jcliburn@gmail.com, chris.snook@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] ethernet/atheros/alx: sanitize buffer sizing and padding From: David Miller In-Reply-To: <1452035554-26145-1-git-send-email-jarod@redhat.com> References: <1452035554-26145-1-git-send-email-jarod@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Jan 2016 22:23:28 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jarod Wilson Date: Tue, 5 Jan 2016 18:12:34 -0500 > - if ((raw_mtu + 8) < ALX_TXQ1_JUMBO_TSO_TH) > - val = (raw_mtu + 8 + 7) >> 3; > + if ((raw_mtu) < ALX_TXQ1_JUMBO_TSO_TH) > + val = (raw_mtu + 7) >> 3; The parenthesis around 'raw_mtu' is superfluous, please remove it. Otherwise this looks great, please resubmit with that fixed up. Thanks.