From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752281AbcAFUFn (ORCPT ); Wed, 6 Jan 2016 15:05:43 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:39408 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751777AbcAFUFl (ORCPT ); Wed, 6 Jan 2016 15:05:41 -0500 Date: Wed, 06 Jan 2016 15:05:39 -0500 (EST) Message-Id: <20160106.150539.179421707935774818.davem@davemloft.net> To: jarod@redhat.com Cc: linux-kernel@vger.kernel.org, eugene.shatokhin@rosalab.ru, prudy1@o2.pl, jcliburn@gmail.com, chris.snook@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH v2 net-next] ethernet/atheros/alx: sanitize buffer sizing and padding From: David Miller In-Reply-To: <1452090997-27683-1-git-send-email-jarod@redhat.com> References: <20160106.012326.1058946039396006074.davem@davemloft.net> <1452090997-27683-1-git-send-email-jarod@redhat.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Jan 2016 12:05:41 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jarod Wilson Date: Wed, 6 Jan 2016 09:36:37 -0500 > This is based on the work done by Przemek Rudy in bug 70761 at > bugzilla.kernel.org, but with some work done to disentagle and clarify > things a bit. > > Similar to Przemek's work and other drivers, we're adding a padding of 16 > here, but we're also disentangling mtu size calculations from max buffer > size calculations a bit, and adding ETH_HLEN to the value written into > ALX_MTU. Hopefully, with a bit more consistency and clarity, things behave > better here. Sadly, I can only test in my alx-driven E2200, which worked > just fine before this patch. > > In comment #58 of bug 70761, Eugene A. Shatokhin reports that this patch > does help considerably for a ROSA Linux user of his with an AR8162 network > adapter when patched into a 4.1.x-based kernel, with several days of > normal operation where wired network previously wasn't usable without > setting MTU to 9000 as a work-around. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=70761 > CC: "Eugene A. Shatokhin" > CC: Przemek Rudy > CC: Jay Cliburn > CC: Chris Snook > CC: netdev@vger.kernel.org > Signed-off-by: Jarod Wilson > --- > v2: remove superfluous parens around raw_mtu, pointed out by davem Looks great, applied, thanks Jarod.