From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752359AbcAFOXV (ORCPT ); Wed, 6 Jan 2016 09:23:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:51624 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbcAFOXS (ORCPT ); Wed, 6 Jan 2016 09:23:18 -0500 Date: Wed, 6 Jan 2016 15:23:15 +0100 From: Petr Mladek To: Torsten Duwe Cc: Steven Rostedt , Michael Ellerman , Jiri Kosina , Denis Kirjanov , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH v5 9/9] Enable LIVEPATCH to be configured on ppc64le and add livepatch.o if it is selected. Message-ID: <20160106142315.GM3178@pathway.suse.cz> References: <20151204152419.28E0D691D2@newverein.lst.de> <20151204152858.2EE5C691D2@newverein.lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151204152858.2EE5C691D2@newverein.lst.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2015-12-04 15:13:44, Torsten Duwe wrote: > Signed-off-by: Torsten Duwe > --- > arch/powerpc/Kconfig | 5 +++++ > arch/powerpc/kernel/Makefile | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index 89b1a2a..62a3f54 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -163,6 +163,9 @@ config PPC > select ARCH_HAS_DMA_SET_COHERENT_MASK > select HAVE_ARCH_SECCOMP_FILTER > > +config HAVE_LIVEPATCH > + def_bool PPC64 && CPU_LITTLE_ENDIAN > + Just a small nitpicking. HAVE_LIVEPATCH is defined in kernel/livepatch/Kconfig. I would move this to the config PPC section and use: select HAVE_LIVEPATCH if PPC64 && CPU_LITTLE_ENDIAN Or did I miss something, please? Best Regards, Petr