From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbcAGI1O (ORCPT ); Thu, 7 Jan 2016 03:27:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51374 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752790AbcAGI1H (ORCPT ); Thu, 7 Jan 2016 03:27:07 -0500 Date: Thu, 7 Jan 2016 09:27:04 +0100 From: Jiri Olsa To: kan.liang@intel.com Cc: peterz@infradead.org, acme@kernel.org, eranian@google.com, ak@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] perf mem: report physical addresses Message-ID: <20160107082704.GE20434@krava.brq.redhat.com> References: <1452078277-15520-1-git-send-email-kan.liang@intel.com> <1452078277-15520-5-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452078277-15520-5-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 06, 2016 at 06:04:34AM -0500, kan.liang@intel.com wrote: > From: Kan Liang > > perf mem report should support physical addresses by applying -p or > --phys-data. The default mem sort order for physical addresses is added > accordingly. > > Signed-off-by: Kan Liang > --- > tools/perf/builtin-mem.c | 15 +++++++++++---- > tools/perf/util/sort.c | 1 + > tools/perf/util/sort.h | 1 + > 3 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c > index 7d5ff3a..a81bdc2 100644 > --- a/tools/perf/builtin-mem.c > +++ b/tools/perf/builtin-mem.c > @@ -6,6 +6,7 @@ > #include "util/tool.h" > #include "util/session.h" > #include "util/data.h" > +#include "util/sort.h" > > #define MEM_OPERATION_LOAD 0x1 > #define MEM_OPERATION_STORE 0x2 > @@ -176,9 +177,15 @@ static int report_events(int argc, const char **argv, struct perf_mem *mem) > * there is no weight (cost) associated with stores, so don't print > * the column > */ > - if (!(mem->operation & MEM_OPERATION_LOAD)) > - rep_argv[i++] = "--sort=mem,sym,dso,symbol_daddr," > - "dso_daddr,tlb,locked"; > + if (!(mem->operation & MEM_OPERATION_LOAD)) { > + if (mem->phys_addr) > + rep_argv[i++] = "--sort=mem,sym,dso,symbol_daddr," > + "dso_daddr,tlb,locked,phys_daddr"; > + else > + rep_argv[i++] = "--sort=mem,sym,dso,symbol_daddr," > + "dso_daddr,tlb,locked"; > + } else if (mem->phys_addr) > + rep_argv[i++] = default_phys_mem_sort_order; should this have "--sort=" as prefix ? thanks, jirka