From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753175AbcAGMim (ORCPT ); Thu, 7 Jan 2016 07:38:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44925 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752448AbcAGMij (ORCPT ); Thu, 7 Jan 2016 07:38:39 -0500 Date: Thu, 7 Jan 2016 20:38:25 +0800 From: Dave Young To: Toshi Kani Cc: akpm@linux-foundation.org, bp@alien8.de, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH v3 07/17] kexec: Set IORESOURCE_SYSTEM_RAM to System RAM Message-ID: <20160107123825.GB2870@dhcp-128-65.nay.redhat.com> References: <1452020081-26534-1-git-send-email-toshi.kani@hpe.com> <1452020081-26534-7-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452020081-26534-7-git-send-email-toshi.kani@hpe.com> User-Agent: Mutt/1.5.23 (2015-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/16 at 11:54am, Toshi Kani wrote: > Set IORESOURCE_SYSTEM_RAM to 'flags' and IORES_DESC_CRASH_KERNEL > to 'desc' of "Crash kernel" resource ranges, which are child > nodes of System RAM. > > Change crash_shrink_memory() to set IORESOURCE_SYSTEM_RAM for > a System RAM range. > > Change kexec_add_buffer() to call walk_iomem_res() with > IORESOURCE_SYSTEM_RAM type for "Crash kernel". > > Cc: Andrew Morton > Cc: Dave Young > Cc: kexec@lists.infradead.org > Signed-off-by: Toshi Kani > --- > kernel/kexec_core.c | 8 +++++--- > kernel/kexec_file.c | 2 +- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c > index 11b64a6..80bff05 100644 > --- a/kernel/kexec_core.c > +++ b/kernel/kexec_core.c > @@ -66,13 +66,15 @@ struct resource crashk_res = { > .name = "Crash kernel", > .start = 0, > .end = 0, > - .flags = IORESOURCE_BUSY | IORESOURCE_MEM > + .flags = IORESOURCE_BUSY | IORESOURCE_SYSTEM_RAM, > + .desc = IORES_DESC_CRASH_KERNEL > }; > struct resource crashk_low_res = { > .name = "Crash kernel", > .start = 0, > .end = 0, > - .flags = IORESOURCE_BUSY | IORESOURCE_MEM > + .flags = IORESOURCE_BUSY | IORESOURCE_SYSTEM_RAM, > + .desc = IORES_DESC_CRASH_KERNEL > }; > > int kexec_should_crash(struct task_struct *p) > @@ -934,7 +936,7 @@ int crash_shrink_memory(unsigned long new_size) > > ram_res->start = end; > ram_res->end = crashk_res.end; > - ram_res->flags = IORESOURCE_BUSY | IORESOURCE_MEM; > + ram_res->flags = IORESOURCE_BUSY | IORESOURCE_SYSTEM_RAM; > ram_res->name = "System RAM"; > > crashk_res.end = end - 1; > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > index b70ada0..c245085 100644 > --- a/kernel/kexec_file.c > +++ b/kernel/kexec_file.c > @@ -523,7 +523,7 @@ int kexec_add_buffer(struct kimage *image, char *buffer, unsigned long bufsz, > /* Walk the RAM ranges and allocate a suitable range for the buffer */ > if (image->type == KEXEC_TYPE_CRASH) > ret = walk_iomem_res("Crash kernel", > - IORESOURCE_MEM | IORESOURCE_BUSY, > + IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY, > crashk_res.start, crashk_res.end, kbuf, > locate_mem_hole_callback); > else Reviewed-by: Dave Young Thanks Dave