From: Dan Williams <dan.j.williams@intel.com>
To: xfs@oss.sgi.com
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
Dave Chinner <dchinner@redhat.com>
Subject: [PATCH v3 4/5] xfs: unmap dax at shutdown (force_failure)
Date: Thu, 07 Jan 2016 16:43:21 -0800 [thread overview]
Message-ID: <20160108004321.36061.17150.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
In-Reply-To: <20160108004254.36061.32864.stgit@dwillia2-desk3.amr.corp.intel.com>
When an exceptional event triggers xfs_force_shutdown() tear down dax
mappings. Quoting Dave,
"The simple fact is that a /filesystem/ shutdown needs to do DAX
mapping invalidation regardless of whether the block device has
been unplugged or not. This is not a case of "this only happens
when we unplug the device", this is a user data protection
mechanism that we use to prevent corruption propagation once it
has been detected. A device unplug is just one type of
"corruption" that can occur."
Acked-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
fs/xfs/xfs_fsops.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
index ee3aaa0a5317..0c6a52809dcc 100644
--- a/fs/xfs/xfs_fsops.c
+++ b/fs/xfs/xfs_fsops.c
@@ -828,6 +828,15 @@ xfs_do_force_shutdown(
if (xfs_log_force_umount(mp, logerror))
return;
+ /*
+ * If DAX is in use, we have to unmap all direct access virtual
+ * mappings to ensure nothing more gets written directly from
+ * userspace. This will force them to refault and that will
+ * result in them detecting the shutdown condition and hence
+ * will fail appropriately.
+ */
+ unmap_dax_inodes(mp->m_super);
+
if (flags & SHUTDOWN_CORRUPT_INCORE) {
xfs_alert_tag(mp, XFS_PTAG_SHUTDOWN_CORRUPT,
"Corruption of in-memory data detected. Shutting down filesystem");
next prev parent reply other threads:[~2016-01-08 0:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 0:42 [PATCH v3 0/5] fs, block: handle end of life Dan Williams
2016-01-08 0:43 ` [PATCH v3 1/5] block: prepare for del_gendisk_queue() Dan Williams
2016-01-08 0:43 ` [PATCH v3 2/5] block: introduce del_gendisk_queue() Dan Williams
2016-01-08 0:43 ` [PATCH v3 3/5] block: introduce force_failure_partition() and unmap_dax_inodes() Dan Williams
2016-01-08 0:43 ` Dan Williams [this message]
2016-01-08 0:43 ` [PATCH v3 5/5] block, xfs: implement 'force_failure' notifications Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108004321.36061.17150.stgit@dwillia2-desk3.amr.corp.intel.com \
--to=dan.j.williams@intel.com \
--cc=dchinner@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®