From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753994AbcAHCFx (ORCPT ); Thu, 7 Jan 2016 21:05:53 -0500 Received: from mga09.intel.com ([134.134.136.24]:32788 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753968AbcAHCFv (ORCPT ); Thu, 7 Jan 2016 21:05:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,536,1444719600"; d="scan'208";a="25640913" Date: Fri, 8 Jan 2016 10:04:41 +0800 From: kbuild test robot To: Jason Gunthorpe Cc: kbuild-all@01.org, Jarkko Sakkinen , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Peter Huewe Subject: [PATCH] tpm_crb: fix ptr_ret.cocci warnings Message-ID: <20160108020441.GA12462@lkp-nex06> References: <201601081058.vDvDPN9c%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452213386-21460-8-git-send-email-jgunthorpe@obsidianresearch.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/char/tpm/tpm_crb.c:297:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Jason Gunthorpe Signed-off-by: Fengguang Wu --- tpm_crb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/char/tpm/tpm_crb.c +++ b/drivers/char/tpm/tpm_crb.c @@ -294,9 +294,7 @@ static int crb_map_io(struct acpi_device memcpy_fromio(&pa, &priv->cca->rsp_pa, 8); pa = le64_to_cpu(pa); priv->rsp = crb_access(dev, priv, pa, ioread32(&priv->cca->rsp_size)); - if (IS_ERR(priv->rsp)) - return PTR_ERR(priv->rsp); - return 0; + return PTR_ERR_OR_ZERO(priv->rsp); } static int crb_acpi_add(struct acpi_device *device)