From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754536AbcAHJIx (ORCPT ); Fri, 8 Jan 2016 04:08:53 -0500 Received: from verein.lst.de ([213.95.11.211]:50419 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754318AbcAHJIt (ORCPT ); Fri, 8 Jan 2016 04:08:49 -0500 Date: Fri, 8 Jan 2016 10:08:46 +0100 From: Christoph Hellwig To: "Nicholas A. Bellinger" Cc: Bart Van Assche , Christoph Hellwig , "Nicholas A. Bellinger" , target-devel , linux-scsi , lkml , Sagi Grimberg , Hannes Reinecke , Andy Grover , Vasu Dev , Vu Pham , Himanshu Madhani , Giridhar Malavali Subject: Re: [PATCH 1/4] target: Obtain se_node_acl->acl_kref during get_initiator_node_acl Message-ID: <20160108090846.GA746@lst.de> References: <1452237348-2277-1-git-send-email-nab@daterainc.com> <1452237348-2277-2-git-send-email-nab@daterainc.com> <20160108081412.GA32138@lst.de> <568F73D2.2090808@sandisk.com> <1452242859.27508.12.camel@haakon3.risingtidesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452242859.27508.12.camel@haakon3.risingtidesystems.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2016 at 12:47:39AM -0800, Nicholas A. Bellinger wrote: > Actually no, they do not. That's the way that everything outside of > tcm_fc + ib_srpt driver code has already worked for a long time. Another reason to introduce a helper to enforce that ordering! Everything but iscsi and qla2xxx is absolutely trivial to convert. qla2xxx needs some work, but I think it's actually wrong currently as it sets the s_id and loop_id unconditionally even if we're reusing an existing node ACL. iscsi is black magic as usual, so I'm a little lost..