From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754571AbcAHNTS (ORCPT ); Fri, 8 Jan 2016 08:19:18 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:41340 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbcAHNTQ (ORCPT ); Fri, 8 Jan 2016 08:19:16 -0500 Date: Fri, 8 Jan 2016 13:19:08 +0000 From: Al Viro To: Andy Shevchenko Cc: Tejun Heo , Linus Walleij , Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "David S . Miller" , David Airlie , Andrew Morton , Rasmus Villemoes Subject: Re: [PATCH v3 0/9] lib/string: introduce match_string() helper Message-ID: <20160108131908.GB17997@ZenIV.linux.org.uk> References: <1452258558-119552-1-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452258558-119552-1-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2016 at 03:09:09PM +0200, Andy Shevchenko wrote: > There are users of a simple string matching in the array. Let's do a common > helper for that. What's the reason for making it return -ENODATA when no match is found? That one of the callers wants to return that as error in such case? At least one other is returning -EINVAL in the same situation...