From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753981AbcAHNgG (ORCPT ); Fri, 8 Jan 2016 08:36:06 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:48935 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbcAHNgE (ORCPT ); Fri, 8 Jan 2016 08:36:04 -0500 Date: Fri, 8 Jan 2016 13:35:45 +0000 From: Russell King - ARM Linux To: Douglas Anderson Cc: Robin Murphy , Tomasz Figa , Marek Szyprowski , Pawel Osciak , Dmitry Torokhov , corbet@lwn.net, akpm@linux-foundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] common: DMA-mapping: add DMA_ATTR_NOHUGEPAGE attribute Message-ID: <20160108133545.GK19062@n2100.arm.linux.org.uk> References: <1452213405-22942-1-git-send-email-dianders@chromium.org> <1452213405-22942-3-git-send-email-dianders@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452213405-22942-3-git-send-email-dianders@chromium.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 07, 2016 at 04:36:44PM -0800, Douglas Anderson wrote: > This patch adds the DMA_ATTR_NOHUGEPAGE attribute to the DMA-mapping > subsystem. It would be nicer to keep things in the positive-logic sense if at all possible: flags that indicate "we don't want something" tend to end up with double or triple negatives somewhere which makes understanding the code much harder. It's a shame we have MADV_NOHUGEPAGE... That's not a strong view, but a preference. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.