From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755663AbcAHP52 (ORCPT ); Fri, 8 Jan 2016 10:57:28 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:44093 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033AbcAHP50 (ORCPT ); Fri, 8 Jan 2016 10:57:26 -0500 Date: Fri, 8 Jan 2016 16:57:23 +0100 From: Andrew Lunn To: Sudip Mukherjee , David Miller Cc: "David S. Miller" , linux-kernel@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, netdev@vger.kernel.org Subject: Re: [PATCH 1/2] phy: fix blackfin build failure Message-ID: <20160108155723.GG4389@lunn.ch> References: <1452252495-20961-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452252495-20961-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2016 at 04:58:14PM +0530, Sudip Mukherjee wrote: > The build of blackfin defconfig is failing with the error: > error: 'struct mii_bus' has no member named 'phy_map' > > A new API mdiobus_get_phy() was introduced and phy_map was removed but > it was not changed here. > > Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus.") > Cc: Andrew Lunn > Signed-off-by: Sudip Mukherjee > --- Hi David. Acked-by: Andrew Lunn This is one more of the late 0-day reports i got. Please take these two, along with the two fixes i posted yesterday. Andrew > > build log of next-20160108 is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/101006125 > > drivers/net/ethernet/adi/bfin_mac.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c > index 6286274..6f3432a 100644 > --- a/drivers/net/ethernet/adi/bfin_mac.c > +++ b/drivers/net/ethernet/adi/bfin_mac.c > @@ -398,7 +398,8 @@ static int mii_probe(struct net_device *dev, int phy_mode) > > /* search for connected PHY device */ > for (i = 0; i < PHY_MAX_ADDR; ++i) { > - struct phy_device *const tmp_phydev = lp->mii_bus->phy_map[i]; > + struct phy_device *const tmp_phydev = > + mdiobus_get_phy(lp->mii_bus, i); > > if (!tmp_phydev) > continue; /* no PHY here... */ > -- > 1.9.1 >