From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932573AbcAHQ6f (ORCPT ); Fri, 8 Jan 2016 11:58:35 -0500 Received: from mail-yk0-f176.google.com ([209.85.160.176]:35402 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932220AbcAHQ6c (ORCPT ); Fri, 8 Jan 2016 11:58:32 -0500 Date: Fri, 8 Jan 2016 11:58:31 -0500 From: Tejun Heo To: Jan Kara Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, Jeff Moyer , Jan Kara Subject: Re: [PATCH 1/5] cfq-iosched: Don't group_idle if cfqq has big thinktime Message-ID: <20160108165831.GU1898@mtj.duckdns.org> References: <1452180496-18483-1-git-send-email-jack@suse.cz> <1452180496-18483-2-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452180496-18483-2-git-send-email-jack@suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Jan. On Thu, Jan 07, 2016 at 04:28:12PM +0100, Jan Kara wrote: > @@ -2947,8 +2948,13 @@ static void cfq_arm_slice_timer(struct cfq_data *cfqd) > return; > } > > - /* There are other queues in the group, don't do group idle */ > - if (group_idle && cfqq->cfqg->nr_cfqq > 1) > + /* > + * There are other queues in the group or this is the only group and > + * it has too big thinktime, don't do group idle. > + */ > + if (group_idle && > + (cfqq->cfqg->nr_cfqq > 1 || > + !cfq_io_thinktime_big(cfqd, &st->ttime, true))) > return; Is the negation in front of the cfq_io_thinktime_big() right? That doesn't seem to match the comment or description. What am I missing? Thanks. -- tejun