From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756622AbcAHS2M (ORCPT ); Fri, 8 Jan 2016 13:28:12 -0500 Received: from mail-yk0-f178.google.com ([209.85.160.178]:34385 "EHLO mail-yk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755767AbcAHS2J (ORCPT ); Fri, 8 Jan 2016 13:28:09 -0500 Date: Fri, 8 Jan 2016 13:28:08 -0500 From: Tejun Heo To: Tang Chen Cc: cl@linux.com, jiang.liu@linux.intel.com, mika.j.penttila@gmail.com, mingo@redhat.com, akpm@linux-foundation.org, rjw@rjwysocki.net, hpa@zytor.com, yasu.isimatu@gmail.com, isimatu.yasuaki@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, gongzhaogang@inspur.com, x86@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/5] x86, memhp, numa: Online memory-less nodes at boot time. Message-ID: <20160108182808.GZ1898@mtj.duckdns.org> References: <1452140425-16577-1-git-send-email-tangchen@cn.fujitsu.com> <1452140425-16577-2-git-send-email-tangchen@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452140425-16577-2-git-send-email-tangchen@cn.fujitsu.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Jan 07, 2016 at 12:20:21PM +0800, Tang Chen wrote: > +static void __init init_memory_less_node(int nid) > { > + unsigned long zones_size[MAX_NR_ZONES] = {0}; > + unsigned long zholes_size[MAX_NR_ZONES] = {0}; It doesn't cause any functional difference but it's a bit weird to use {0} because it explicitly says to initialize the first element to 0 when the whole array needs to be cleared. Wouldnt { } make more sense? > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index e23a9e7..9c4d4d5 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -736,6 +736,7 @@ static inline bool is_dev_zone(const struct zone *zone) > > extern struct mutex zonelists_mutex; > void build_all_zonelists(pg_data_t *pgdat, struct zone *zone); > +void build_zonelists(pg_data_t *pgdat); This isn't used in this patch. Contamination? Thanks. -- tejun