From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754448AbcAHTNK (ORCPT ); Fri, 8 Jan 2016 14:13:10 -0500 Received: from mail-yk0-f172.google.com ([209.85.160.172]:35958 "EHLO mail-yk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751897AbcAHTNH (ORCPT ); Fri, 8 Jan 2016 14:13:07 -0500 Date: Fri, 8 Jan 2016 14:13:05 -0500 From: Tejun Heo To: Tang Chen Cc: cl@linux.com, jiang.liu@linux.intel.com, mika.j.penttila@gmail.com, mingo@redhat.com, akpm@linux-foundation.org, rjw@rjwysocki.net, hpa@zytor.com, yasu.isimatu@gmail.com, isimatu.yasuaki@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, gongzhaogang@inspur.com, x86@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Gu Zheng Subject: Re: [PATCH 5/5] x86, acpi, cpu-hotplug: Set persistent cpuid <-> nodeid mapping when booting. Message-ID: <20160108191305.GA1898@mtj.duckdns.org> References: <1452140425-16577-1-git-send-email-tangchen@cn.fujitsu.com> <1452140425-16577-6-git-send-email-tangchen@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452140425-16577-6-git-send-email-tangchen@cn.fujitsu.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Tang. On Thu, Jan 07, 2016 at 12:20:25PM +0800, Tang Chen wrote: > From: Gu Zheng > > This patch finishes step 4. This doesn't help people trying to read the patch. If you wanna say it's one of the steps of something, you also need to say what the steps are. No need to duplicate the whole thing but a short summary would be helpful. > This patch set the persistent cpuid <-> nodeid mapping for all enabled/disabled > processors at boot time via an additional acpi namespace walk for processors. So, the patchset generally looks good to me although I'm not too familiar with acpi. Rafael, Len, what do you think? Thanks. -- tejun