From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753056AbcAIHzy (ORCPT <rfc822;w@1wt.eu>);
	Sat, 9 Jan 2016 02:55:54 -0500
Received: from bombadil.infradead.org ([198.137.202.9]:60477 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752198AbcAIHzx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 9 Jan 2016 02:55:53 -0500
Date: Fri, 8 Jan 2016 23:55:48 -0800
From: Christoph Hellwig <hch@infradead.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Robin Murphy <robin.murphy@arm.com>, Tomasz Figa <tfiga@chromium.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Pawel Osciak <pawel@osciak.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] common: DMA-mapping: add DMA_ATTR_NOHUGEPAGE
 attribute
Message-ID: <20160109075548.GB25059@infradead.org>
References: <1452213405-22942-1-git-send-email-dianders@chromium.org>
 <1452213405-22942-3-git-send-email-dianders@chromium.org>
 <20160108133545.GK19062@n2100.arm.linux.org.uk>
 <CAD=FV=WnxzvSYFb5cWVLR7O_PRw8niENDg2DXLX+o0F6FH-E7w@mail.gmail.com>
 <20160108231806.GP19062@n2100.arm.linux.org.uk>
 <CAD=FV=W8h45qnhH-a8--fUS=ObJhBu77ZCJn2QOB5NsMoFesnA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAD=FV=W8h45qnhH-a8--fUS=ObJhBu77ZCJn2QOB5NsMoFesnA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org
	See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 08, 2016 at 03:31:29PM -0800, Doug Anderson wrote:
> Ah, that makes so much more sense now!  :)  So you were suggesting
> something like DMA_ATTR_SMALL_PAGES_OK.  Then you if we wanted all
> possible states you'd have 0 vs. DMA_ATTR_SMALL_PAGES_OK vs.
> DMA_ATTR_HUGE_PAGE?  That would avoid the double-negative but does
> have the downside that it's less obvious that DMA_ATTR_SMALL_PAGES_OK
> is the opposite of DMA_ATTR_HUGE_PAGE.

or DMA_ATTR_4K_PAGES if that's what you want.  We have at least 4k, 8k,
16k and 64k page support in the kernel, not sure if 32k and 256k ever
made it mainline.  What does your hardware actually require?

This needs to be documented properly and hpefully also reflected in the
name of the fag.  Otherwise we'll end up with a giant desaster like
GFP_DMA that means something slightly different on every architecture.