mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure
Date: Sat, 9 Jan 2016 10:29:08 -0800	[thread overview]
Message-ID: <20160109182908.GB29967@kroah.com> (raw)
In-Reply-To: <1452363335-2535-1-git-send-email-linux@roeck-us.net>

On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> If serial/atmel_serial.c is compiled with devicetree enabled, the
> following build error is observed.
> 
> drivers/tty/serial/atmel_serial.c:192:1: warning:
> 	data definition has no type or storage class
> drivers/tty/serial/atmel_serial.c:192:1: error:
> 	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> drivers/tty/serial/atmel_serial.c:192:1: warning:
> 	parameter names (without types) in function declaration
> 
> MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.
> 
> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/tty/serial/atmel_serial.c | 1 +
>  1 file changed, 1 insertion(+)

This hit my tree last night already with commit
041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the
next linux-next release.

thanks,

greg k-h

  reply	other threads:[~2016-01-09 18:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-09 18:15 Guenter Roeck
2016-01-09 18:29 ` Greg Kroah-Hartman [this message]
2016-01-11  8:35   ` Sudip Mukherjee
2016-01-11 11:11     ` Guenter Roeck
2016-01-11 11:34       ` Sudip Mukherjee
2016-01-11 15:08       ` Paul Gortmaker
2016-01-13  5:35         ` Guenter Roeck
2016-01-13  5:44           ` Joe Perches
2016-01-13 10:32             ` Sudip Mukherjee
2016-01-13 13:06               ` Guenter Roeck
2016-01-13 15:06               ` Joe Perches
2016-01-18 16:36               ` Guenter Roeck
2016-01-18 17:04                 ` Sudip Mukherjee
2016-01-18 17:17                   ` Guenter Roeck
2016-01-20  5:51                     ` Sudip Mukherjee
2016-01-20  6:27                       ` Guenter Roeck
2016-01-20  6:32                         ` Sudip Mukherjee
2016-01-13 10:29           ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160109182908.GB29967@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nicolas.ferre@atmel.com \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome