From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756223AbcAIVXw (ORCPT ); Sat, 9 Jan 2016 16:23:52 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:44637 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755928AbcAIVXv (ORCPT ); Sat, 9 Jan 2016 16:23:51 -0500 Date: Sat, 9 Jan 2016 22:23:47 +0100 From: Andrew Lunn To: Guenter Roeck Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] net: ti: cpmac: Fix build error due to missed API change Message-ID: <20160109212347.GB6877@lunn.ch> References: <1452374379-18644-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452374379-18644-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 09, 2016 at 01:19:39PM -0800, Guenter Roeck wrote: > Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to > a bus") introduces an API to access mii_bus structures, but missed to > update the TI cpamc driver. This results in the following error message. > > drivers/net/ethernet/ti/cpmac.c: In function 'cpmac_probe': > drivers/net/ethernet/ti/cpmac.c:1119:18: error: > 'struct mii_bus' has no member named 'phy_map' > > Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus") > Cc: Andrew Lunn > Signed-off-by: Guenter Roeck Acked-by: Andrew Lunn Thanks Andrew > --- > drivers/net/ethernet/ti/cpmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c > index 0b483301767d..7eef45e6d70a 100644 > --- a/drivers/net/ethernet/ti/cpmac.c > +++ b/drivers/net/ethernet/ti/cpmac.c > @@ -1116,7 +1116,7 @@ static int cpmac_probe(struct platform_device *pdev) > for (phy_id = 0; phy_id < PHY_MAX_ADDR; phy_id++) { > if (!(pdata->phy_mask & (1 << phy_id))) > continue; > - if (!cpmac_mii->phy_map[phy_id]) > + if (!mdiobus_get_phy(cpmac_mii, phy_id)) > continue; > strncpy(mdio_bus_id, cpmac_mii->id, MII_BUS_ID_SIZE); > break; > -- > 2.1.4 >