From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758173AbcAKDGE (ORCPT ); Sun, 10 Jan 2016 22:06:04 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:60432 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758080AbcAKDGC (ORCPT ); Sun, 10 Jan 2016 22:06:02 -0500 Date: Sun, 10 Jan 2016 22:06:00 -0500 (EST) Message-Id: <20160110.220600.1571134071098680158.davem@davemloft.net> To: linux@roeck-us.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch Subject: Re: [PATCH -next] net: ethernet: broadcom: Fix build errors From: David Miller In-Reply-To: <1452456196-1624-1-git-send-email-linux@roeck-us.net> References: <1452456196-1624-1-git-send-email-linux@roeck-us.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 10 Jan 2016 19:06:02 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guenter Roeck Date: Sun, 10 Jan 2016 12:03:16 -0800 > Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to > a bus") introduces an API to access mii_bus structures, but missed to > update the sb1250 driver. This results in the following build error. > > drivers/net/ethernet/broadcom/sb1250-mac.c: In function 'sbmac_mii_probe': > drivers/net/ethernet/broadcom/sb1250-mac.c:2360:24: error: > 'struct mii_bus' has no member named 'phy_map' > > Use phy_find_first() instead of open coding it. > > Commit 2220943a21e2 ("phy: Centralise print about attached phy") introduces > the following build error. > > drivers/net/ethernet/broadcom/sb1250-mac.c: In function 'sbmac_mii_probe': > drivers/net/ethernet/broadcom/sb1250-mac.c:2383:20: error: 'phydev' undeclared > > Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus") > Fixes: 2220943a21e2 ("phy: Centralise print about attached phy") > Cc: Andrew Lunn > Signed-off-by: Guenter Roeck Applied.