From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758349AbcAKEar (ORCPT ); Sun, 10 Jan 2016 23:30:47 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:32897 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757979AbcAKEap (ORCPT ); Sun, 10 Jan 2016 23:30:45 -0500 Date: Sun, 10 Jan 2016 23:30:43 -0500 (EST) Message-Id: <20160110.233043.1721701935879616026.davem@davemloft.net> To: andrew@lunn.ch Cc: linux@roeck-us.net, =adi-buildroot-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next v2] net: bfin_mac: Fix build error due to missed API change From: David Miller In-Reply-To: <20160110154532.GB22229@lunn.ch> References: <1452438484-29205-1-git-send-email-linux@roeck-us.net> <20160110154532.GB22229@lunn.ch> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 10 Jan 2016 20:30:45 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Lunn Date: Sun, 10 Jan 2016 16:45:32 +0100 > On Sun, Jan 10, 2016 at 07:08:04AM -0800, Guenter Roeck wrote: >> Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to >> a bus") introduces an API to access mii_bus structures, but missed to >> update the bfin_mac driver. This results in the following error message >> >> drivers/net/ethernet/adi/bfin_mac.c: In function 'mii_probe': >> drivers/net/ethernet/adi/bfin_mac.c:401:52: error: >> 'struct mii_bus' has no member named 'phy_map' >> >> Use phy_find_first() instead of open-coding it. >> >> Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus") >> Cc: Andrew Lunn >> Signed-off-by: Guenter Roeck > > Acked-by: Andrew Lunn > > Hi Dave > > Although Sadip Mukerjee's patch [PATCH 1/2] phy: fix blackfin build failure > is correct, this one is better. Please take this one in preference. > We do still however need Sadip's [2/2] bfin_mac: fix error path Sorry, I applied Sadip's patch already. I'll need to get something relative if you really want this variant in my tree. Thanks.