From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757249AbcAJPps (ORCPT ); Sun, 10 Jan 2016 10:45:48 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:44939 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756162AbcAJPpr (ORCPT ); Sun, 10 Jan 2016 10:45:47 -0500 Date: Sun, 10 Jan 2016 16:45:32 +0100 From: Andrew Lunn To: Guenter Roeck Cc: "David S. Miller" , =adi-buildroot-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next v2] net: bfin_mac: Fix build error due to missed API change Message-ID: <20160110154532.GB22229@lunn.ch> References: <1452438484-29205-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452438484-29205-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 10, 2016 at 07:08:04AM -0800, Guenter Roeck wrote: > Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to > a bus") introduces an API to access mii_bus structures, but missed to > update the bfin_mac driver. This results in the following error message > > drivers/net/ethernet/adi/bfin_mac.c: In function 'mii_probe': > drivers/net/ethernet/adi/bfin_mac.c:401:52: error: > 'struct mii_bus' has no member named 'phy_map' > > Use phy_find_first() instead of open-coding it. > > Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus") > Cc: Andrew Lunn > Signed-off-by: Guenter Roeck Acked-by: Andrew Lunn Hi Dave Although Sadip Mukerjee's patch [PATCH 1/2] phy: fix blackfin build failure is correct, this one is better. Please take this one in preference. We do still however need Sadip's [2/2] bfin_mac: fix error path Andrew