From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761585AbcAKWQX (ORCPT ); Mon, 11 Jan 2016 17:16:23 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:41690 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbcAKWQV (ORCPT ); Mon, 11 Jan 2016 17:16:21 -0500 Date: Mon, 11 Jan 2016 17:16:19 -0500 (EST) Message-Id: <20160111.171619.1907777399182966008.davem@davemloft.net> To: jarod@redhat.com Cc: linux-kernel@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com, gospo@cumulusnetworks.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] bonding: make mii_status sysfs node consistent From: David Miller In-Reply-To: <1452303336-28203-1-git-send-email-jarod@redhat.com> References: <1452303336-28203-1-git-send-email-jarod@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Jan 2016 14:16:21 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jarod Wilson Date: Fri, 8 Jan 2016 20:35:36 -0500 > The spew in /proc/net/bonding/bond0 uses netif_carrier_ok() to determine > mii_status, while /sys/class/net/bond0/bonding/mii_status looks at > curr_active_slave, which doesn't actually seem to be set sometimes when > the bond actually is up. A mode 4 bond configured via ifcfg-foo files on a > Red Hat Enterprise Linux system, after boot, comes up clean and > functional, but the sysfs node shows mii_status of down, while proc shows > up. A simple enough fix here seems to be to use the same method for > determining up or down in both places, and I'd opt for the one that seems > to match reality. > > CC: Jay Vosburgh > CC: Veaceslav Falico > CC: Andy Gospodarek > CC: netdev@vger.kernel.org > Signed-off-by: Jarod Wilson Seems reasonable, applied, thanks.