From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932967AbcAKWR0 (ORCPT ); Mon, 11 Jan 2016 17:17:26 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:41704 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbcAKWRZ (ORCPT ); Mon, 11 Jan 2016 17:17:25 -0500 Date: Mon, 11 Jan 2016 17:17:23 -0500 (EST) Message-Id: <20160111.171723.14314277123423031.davem@davemloft.net> To: sjoerd.simons@collabora.co.uk Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH] net: phy: turn carrier off on phy attach From: David Miller In-Reply-To: <1452365045-5364-1-git-send-email-sjoerd.simons@collabora.co.uk> References: <1452365045-5364-1-git-send-email-sjoerd.simons@collabora.co.uk> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Jan 2016 14:17:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sjoerd Simons Date: Sat, 9 Jan 2016 19:44:05 +0100 > The operstate of a networking device initially IF_OPER_UNKNOWN aka > "unknown", updated on carrier state changes (with carrier state being on > by default). This means it will stay unknown unless the carrier state > goes to off at some point, which is not the case if the phy is already > up/connected at startup. > > Explicitly turn off the carrier on phy attach, leaving the phy state > machine to turn the carrier on when it has done the initial negotiation. > > Signed-off-by: Sjoerd Simons Florian or Andrew, please review this. Thanks. > > --- > > drivers/net/phy/phy_device.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 0bfbaba..a30ce1a 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -668,6 +668,11 @@ int phy_attach_direct(struct net_device *dev, struct phy_device *phydev, > > phydev->state = PHY_READY; > > + /* Signal to the core network layer the phy supports > + * carrier detection > + */ > + netif_carrier_off(phydev->attached_dev); > + > /* Do initial configuration here, now that > * we have certain key parameters > * (dev_flags and interface) > -- > 2.7.0.rc3 >