From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760610AbcAKWmK (ORCPT ); Mon, 11 Jan 2016 17:42:10 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:42036 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbcAKWmH (ORCPT ); Mon, 11 Jan 2016 17:42:07 -0500 Date: Mon, 11 Jan 2016 17:42:05 -0500 (EST) Message-Id: <20160111.174205.202764956086980022.davem@davemloft.net> To: mkubecek@suse.cz Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hannes@stressinduktion.org, shannon.nelson@intel.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net Subject: Re: [PATCH net] udp: disallow UFO for sockets with SO_NO_CHECK option From: David Miller In-Reply-To: <20160111065030.F3FFCA0EF1@unicorn.suse.cz> References: <20160111065030.F3FFCA0EF1@unicorn.suse.cz> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Jan 2016 14:42:07 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kubecek Date: Mon, 11 Jan 2016 07:50:30 +0100 (CET) > Commit acf8dd0a9d0b ("udp: only allow UFO for packets from SOCK_DGRAM > sockets") disallows UFO for packets sent from raw sockets. We need to do > the same also for SOCK_DGRAM sockets with SO_NO_CHECK options, even if > for a bit different reason: while such socket would override the > CHECKSUM_PARTIAL set by ip_ufo_append_data(), gso_size is still set and > bad offloading flags warning is triggered in __skb_gso_segment(). > > In the IPv6 case, SO_NO_CHECK option is ignored but we need to disallow > UFO for packets sent by sockets with UDP_NO_CHECK6_TX option. > > Signed-off-by: Michal Kubecek > Tested-by: Shannon Nelson Applied and queued up for -stable, thanks Michal.