From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760009AbcAKOA5 (ORCPT ); Mon, 11 Jan 2016 09:00:57 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47644 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759362AbcAKOAy (ORCPT ); Mon, 11 Jan 2016 09:00:54 -0500 Date: Mon, 11 Jan 2016 14:00:38 +0000 From: Mark Brown To: Fabio Estevam Cc: "Maciej S. Szmigiero" , "alsa-devel@alsa-project.org" , Timur Tabi , Nicolin Chen , Xiubo Li , Liam Girdwood , "linuxppc-dev@lists.ozlabs.org" , linux-kernel Message-ID: <20160111140038.GC6588@sirena.org.uk> References: <5677107C.60904@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hI0LKvM4dmXJ5Wy2" Content-Disposition: inline In-Reply-To: X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hI0LKvM4dmXJ5Wy2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 11, 2016 at 10:10:56AM -0200, Fabio Estevam wrote: > On Mon, Jan 11, 2016 at 10:04 AM, Fabio Estevam wrote: > > [ 2.526984] ------------[ cut here ]------------ > > [ 2.531632] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:2755 > > lockdep_trace_alloc+0xf4/0x124() > This fixes the warning: > --- a/sound/soc/fsl/fsl_ssi.c > +++ b/sound/soc/fsl/fsl_ssi.c > @@ -180,7 +180,6 @@ static const struct regmap_config fsl_ssi_regconfig = { > .volatile_reg = fsl_ssi_volatile_reg, > .precious_reg = fsl_ssi_precious_reg, > .writeable_reg = fsl_ssi_writeable_reg, > - .cache_type = REGCACHE_RBTREE, > }; > Is this the correct fix? I suspect not, it looks like the driver is using the cache for suspend/resume handling. I've dropped the patch for now. Either the driver should explicitly write to the relevant registers outside of interrupt context to ensure the cache entry exists or it should keep the defaults and explicitly write them to hardware at startup to ensure sync (the former is more likely to be safe). --hI0LKvM4dmXJ5Wy2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWk7WFAAoJECTWi3JdVIfQqwMH/igsSpD64+/Csx8zYZBUH/pX CmUjBDptMDMUTqpKcUd/eo7wCnAuFClaMjI50f06Gr12FMvCjfqmxAbCR+dvUBfk MfLE7ofTq8cgzkmXYpMFaIxvkkeIxwF5PBlhIfPGTNuZ86V4MRtf4P8uOKLNW7EF 5HB3tzw+ehuQt+aolGy3rx6Db9JiCX5ad6oT5ZfJC4tVAcQFiW5Bo+YnK67ON1m9 fp7wyoDW8n+zkbJsgonDHNIvtTtPvfwmkqU6HKy9suhaIycMHCUI8nprHbUwNC6C mxe2so2kRfNrwk9UCeQWsKcXlYGHcCd4Pe3pT3WCeHFQj1k+m04TjyeCce2dtYo= =h59D -----END PGP SIGNATURE----- --hI0LKvM4dmXJ5Wy2--