From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760103AbcAKOyr (ORCPT ); Mon, 11 Jan 2016 09:54:47 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47746 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757612AbcAKOyq (ORCPT ); Mon, 11 Jan 2016 09:54:46 -0500 Date: Mon, 11 Jan 2016 14:54:30 +0000 From: Mark Brown To: "Maciej S. Szmigiero" Cc: Fabio Estevam , "alsa-devel@alsa-project.org" , Timur Tabi , Nicolin Chen , Xiubo Li , Liam Girdwood , "linuxppc-dev@lists.ozlabs.org" , linux-kernel Message-ID: <20160111145430.GE6588@sirena.org.uk> References: <5677107C.60904@maciej.szmigiero.name> <20160111140038.GC6588@sirena.org.uk> <5693B7CC.8000905@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="afaOoWBOIwPZGAW2" Content-Disposition: inline In-Reply-To: <5693B7CC.8000905@maciej.szmigiero.name> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --afaOoWBOIwPZGAW2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 11, 2016 at 03:10:20PM +0100, Maciej S. Szmigiero wrote: > On 11.01.2016 15:00, Mark Brown wrote: > > I suspect not, it looks like the driver is using the cache for > > suspend/resume handling. I've dropped the patch for now. Either the > > driver should explicitly write to the relevant registers outside of > > interrupt context to ensure the cache entry exists or it should keep the > > defaults and explicitly write them to hardware at startup to ensure > > sync (the former is more likely to be safe). > Is it acceptable to switch it to flat cache instead to not keep the register > defaults in driver? That's possibly problematic because the flat cache will of necessity end up with defaults (of 0 from the kzalloc()) for all the registers. You'll still have default values in the cache, though some of the behaviour around optimising syncs does change without them explicitly given. It does deal with the allocation issue but given that the issue was incorrect defaults I'd be a bit concerned. --afaOoWBOIwPZGAW2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWk8ImAAoJECTWi3JdVIfQtbwH/Rj4YZZjRlI6a3XFpGZnHQFg MB6Kqu0NLWiwareNiaiCL+0HEI2H6AU4qmGrEiaEDsptiC7Tmn0H9cS1ureQFkvX pWyyBvjBiegDeAbQ54H69CJ3Kidqyq3Y1TN6uX4mRS1nTFHf9YK4hi7FlVBnIfME pmvBVykU8DUd53CglRa3IaTGdj7F5ULbnWbK4R0FRDGXf8l73VbxfuNoGXJZUtWj qydpBvul5ErCw/bLEnGy81RLSi82TvjjnZA+s+sR5pjWtOlWnP8orX5y1E9qQ0Op mzleOfl48qmMQtAEvxJBuWrkuzqUzKDYRp+zsZAgQ9BJR5sS8agi+k4m5YsNLzs= =h5cq -----END PGP SIGNATURE----- --afaOoWBOIwPZGAW2--