From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760207AbcAKPkM (ORCPT ); Mon, 11 Jan 2016 10:40:12 -0500 Received: from mx2.suse.de ([195.135.220.15]:42126 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757307AbcAKPkK (ORCPT ); Mon, 11 Jan 2016 10:40:10 -0500 Date: Mon, 11 Jan 2016 16:40:19 +0100 From: Jan Kara To: Tejun Heo Cc: Jan Kara , axboe@kernel.dk, linux-kernel@vger.kernel.org, Jeff Moyer , Jan Kara Subject: Re: [PATCH 1/5] cfq-iosched: Don't group_idle if cfqq has big thinktime Message-ID: <20160111154019.GH6262@quack.suse.cz> References: <1452180496-18483-1-git-send-email-jack@suse.cz> <1452180496-18483-2-git-send-email-jack@suse.cz> <20160108165831.GU1898@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160108165831.GU1898@mtj.duckdns.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 08-01-16 11:58:31, Tejun Heo wrote: > Hello, Jan. > > On Thu, Jan 07, 2016 at 04:28:12PM +0100, Jan Kara wrote: > > @@ -2947,8 +2948,13 @@ static void cfq_arm_slice_timer(struct cfq_data *cfqd) > > return; > > } > > > > - /* There are other queues in the group, don't do group idle */ > > - if (group_idle && cfqq->cfqg->nr_cfqq > 1) > > + /* > > + * There are other queues in the group or this is the only group and > > + * it has too big thinktime, don't do group idle. > > + */ > > + if (group_idle && > > + (cfqq->cfqg->nr_cfqq > 1 || > > + !cfq_io_thinktime_big(cfqd, &st->ttime, true))) > > return; > > Is the negation in front of the cfq_io_thinktime_big() right? That > doesn't seem to match the comment or description. What am I missing? Ah, you are right! I wanted to make arming of group_idle timer consistent with what we test in cfq_should_idle() for normal idle timer but I accidentally reverted the condition. I'll fix this. Honza -- Jan Kara SUSE Labs, CR