From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761244AbcAKSYv (ORCPT ); Mon, 11 Jan 2016 13:24:51 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48003 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761172AbcAKSYt (ORCPT ); Mon, 11 Jan 2016 13:24:49 -0500 Date: Mon, 11 Jan 2016 18:24:44 +0000 From: Mark Brown To: Chen Feng Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, yudongbin@hisilicon.com, saberlily.xia@hisilicon.com, suzhuangluan@hisilicon.com, kong.kongxinwei@hisilicon.com, xuyiping@hisilicon.com, z.liuxinliang@hisilicon.com, puck.chenfeng@gmail.com, weidong2@hisilicon.com, w.f@huawei.com, qijiwen@hisilicon.com, peter.panshilin@hisilicon.com, dan.zhao@hisilicon.com, linuxarm@huawei.com, liguozhu@hisilicon.com Message-ID: <20160111182444.GR6588@sirena.org.uk> References: <1452514817-118311-1-git-send-email-puck.chen@hisilicon.com> <1452514817-118311-5-git-send-email-puck.chen@hisilicon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="U/OZNOFFJieNpJU4" Content-Disposition: inline In-Reply-To: <1452514817-118311-5-git-send-email-puck.chen@hisilicon.com> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v5 4/5] regulator: add regulator driver of hi655x pmic X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --U/OZNOFFJieNpJU4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 11, 2016 at 08:20:16PM +0800, Chen Feng wrote: > +config REGULATOR_HI655X > + tristate "Hisilicon HI655X PMIC regulators support" > + depends on ARCH_HISI || (COMPILE_TEST && ARM64) Why does this depend on ARM64? If it's needed it probably indicates a problem... > + np = of_get_child_by_name(dev->parent->of_node, "regulators"); > + if (!np) > + return -ENODEV; > + > + ret = of_regulator_match(dev, np, > + hi655x_regulator_match, > + ARRAY_SIZE(hi655x_regulator_match)); Like I said on the previous version: | Don't open code this, use the standard support with of_match and | regulators_node. The code is now using of_match but still open coding regulators_node. --U/OZNOFFJieNpJU4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWk/NrAAoJECTWi3JdVIfQdKwH/jfGNaPDJmbFZiEUd9z7GXVH gF5dDR9exTZD8fHGuhY24o29UeJpt+6NrD0KXDrdhho7K6DIg4cMk1Q7JBqQpqlO jiYmB8wcjHPSZvFPyNMSN/ZcL/r/5+xswJvZVieSo9uVhg/aExWESalW6DrMIfh9 ADUR2o5Cd+NxgySnUex3zBuEVJTzyrBZj0lVFO4+Fpv/wyh86vD8h/bhTXa+NZAt ngv7MYXD18HxXLTMgqp47C7TFZVgdfd14uPryinT0DLD0b9TjBIKgZuoVZ1um6i9 3qzhyP7Bg140vXTZZXcfhSKr+xgjBGDoeoruqdZK3KI1yjPn4KTmUghr91OLApE= =OQ7s -----END PGP SIGNATURE----- --U/OZNOFFJieNpJU4--