From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751626AbcALTbX (ORCPT ); Tue, 12 Jan 2016 14:31:23 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:53260 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752052AbcALTbN (ORCPT ); Tue, 12 Jan 2016 14:31:13 -0500 Date: Tue, 12 Jan 2016 14:31:12 -0500 (EST) Message-Id: <20160112.143112.1804837472013389455.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] mdio_bus: NULL dereference on allocation error From: David Miller In-Reply-To: <20160112093435.GD29804@mwanda> References: <20160112093435.GD29804@mwanda> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Jan 2016 11:31:13 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter Date: Tue, 12 Jan 2016 12:34:36 +0300 > If bus = kzalloc() fails then we end up dereferencing bus when we do > "bus->irq[i] = PHY_POLL;". The code is a little simpler if we reverse > the NULL check and return directly on failure. > > Fixes: e7f4dc3536a4 ('mdio: Move allocation of interrupts into core') > Signed-off-by: Dan Carpenter Applied.