From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965350AbcALMdh (ORCPT ); Tue, 12 Jan 2016 07:33:37 -0500 Received: from ozlabs.org ([103.22.144.67]:34090 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761391AbcALMcq (ORCPT ); Tue, 12 Jan 2016 07:32:46 -0500 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 57f7c3932516b9f7908d9b0a24396112d0f4ca55 In-Reply-To: <1452277810-98195-2-git-send-email-computersforpeace@gmail.com> To: Brian Norris , Ian Munsie , Michael Neuling From: Michael Ellerman Cc: Arnd Bergmann , Anton Blanchard , linux-kernel@vger.kernel.org, Michal Marek , Joe Perches , Brian Norris , linuxppc-dev@lists.ozlabs.org Subject: Re: [v2,2/2] cxl: use -Werror only with CONFIG_PPC_WERROR Message-Id: <20160112123245.7152514076E@ozlabs.org> Date: Tue, 12 Jan 2016 23:32:45 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-08-01 at 18:30:10 UTC, Brian Norris wrote: > Some developers really like to have -Werror enabled for their code, as > it helps to ensure warning free code. Others don't want -Werror, as it > (for example) can cause problems when newer (or older) compilers have > different sets of warnings, or new warnings can appear just when turning > up the warning level (e.g., make W=1 or W=2). Thus, it seems prudent to > have the use of -Werror be configurable. > > It so happens that cxl is only built on PowerPC, and PowerPC already > has a nice set of Kconfig options for this, under CONFIG_PPC_WERROR. So > let's use that, and the world is a happy place again! (Note that > PPC_WERROR defaults to =y, so the common case compile should still be > enforcing -Werror.) > > Fixes: d3d73f4b38a8 ("cxl: Compile with -Werror") > Signed-off-by: Brian Norris Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/57f7c3932516b9f7908d9b0a24 cheers