From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753782AbcALUkc (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jan 2016 15:40:32 -0500
Received: from mail-pa0-f66.google.com ([209.85.220.66]:32878 "EHLO
	mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752529AbcALUka convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jan 2016 15:40:30 -0500
Date: Tue, 12 Jan 2016 12:40:23 -0800
From: Joshua Clayton <stillcompiling@gmail.com>
To: Lucas Stach <dev@lynxeye.de>
Cc: Thierry Reding <thierry.reding@gmail.com>, David Airlie <airlied@linux.ie>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04
Message-ID: <20160112124023.1ef170d5@jclayton-pc>
In-Reply-To: <1452624330.2628.3.camel@lynxeye.de>
References: <1452614746-7841-1-git-send-email-stillcompiling@gmail.com>
	<1452624330.2628.3.camel@lynxeye.de>
X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Lucas,
Thanks for the review. 

On Tue, 12 Jan 2016 19:45:30 +0100
Lucas Stach <dev@lynxeye.de> wrote:

> >  drivers/gpu/drm/panel/panel-simple.c | 26
> > ++++++++++++++++++++++++++
> 
> Missing documentation for the DT binding.
>

Thanks, will add. 

...

> > +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> > +};
> > +
> This hunk isn't added at the correct place. Please keep the
> alphabetical sorting.
OK. Makes sense. I'll reorder these.
> 
> >  static const struct display_timing hannstar_hsd070pww1_timing = {
> >  	.pixelclock = { 64300000, 71100000, 82000000 },
> >  	.hactive = { 1280, 1280, 1280 },
> > @@ -1146,6 +1169,9 @@ static const struct of_device_id
> > platform_of_match[] = {
> >  		.compatible = "hannstar,hsd070pww1",
> >  		.data = &hannstar_hsd070pww1,
> >  	}, {
> > +		.compatible = "sharp,lq101k1ly04",
> > +		.data = &sharp_lq101k1ly04,
> > +	}, {
> 
> Wrong insertion place again.
OK. Will reorder alphabetically also. 

Joshua