From: Mark Brown <broonie@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [GIT PULL] regulator updates for v4.5
Date: Tue, 12 Jan 2016 18:12:21 +0000 [thread overview]
Message-ID: <20160112181221.GB6588@sirena.org.uk> (raw)
In-Reply-To: <CA+55aFwf6QxWG8djy4sS=o1yVk6R3+Nk9H5S8b=pATOhR06OsQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
On Tue, Jan 12, 2016 at 09:48:54AM -0800, Linus Torvalds wrote:
> Nope. No can do.
> I get a build error:
> drivers/regulator/max8973-regulator.c:506:4: error:
> ‘THERMAL_DEVICE_EVENT_THRESHOLD’ undeclared
> and grepping around for this that is not some merge error: even in
> your tree (before being merged into mine), that thing simply does not
> exist except in that one place:
> [torvalds@i7 linux]$ git grep THERMAL_DEVICE_EVENT_THRESHOLD 2986a09d8
> 2986a09d8:drivers/regulator/max8973-regulator.c:
> THERMAL_DEVICE_EVENT_THRESHOLD);
> and that's it.
> So this tree clearly can never have worked, and never have compiled.
> Consider yourself cursed at.
Ugh, right. It builds fine in -next because that has been introduced in
the thermal tree and that gets merged first (the code had been there), I
hadn't updated the local test configs and for some reason the kernelci
results got lost in the noise.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-12 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 9:54 Mark Brown
2016-01-12 17:48 ` Linus Torvalds
2016-01-12 17:50 ` Linus Torvalds
2016-01-12 18:20 ` Mark Brown
2016-01-12 18:12 ` Mark Brown [this message]
2016-01-15 16:27 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112181221.GB6588@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®