From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753580AbcALWWG (ORCPT ); Tue, 12 Jan 2016 17:22:06 -0500 Received: from mail-ob0-f169.google.com ([209.85.214.169]:33009 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752489AbcALWWE (ORCPT ); Tue, 12 Jan 2016 17:22:04 -0500 Date: Tue, 12 Jan 2016 16:22:01 -0600 From: Andy Gross To: Srinivas Kandagatla Cc: Arnd Bergmann , linux-arm-msm@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support Message-ID: <20160112222201.GA4125@hector.attlocal.net> References: <1452606358-24569-1-git-send-email-srinivas.kandagatla@linaro.org> <1452606392-24614-1-git-send-email-srinivas.kandagatla@linaro.org> <7998607.BblzgPxGPW@wuerfel> <56950E0A.2000005@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56950E0A.2000005@linaro.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2016 at 02:30:34PM +0000, Srinivas Kandagatla wrote: > > > On 12/01/16 13:59, Arnd Bergmann wrote: > >On Tuesday 12 January 2016 13:46:32 Srinivas Kandagatla wrote: > >> }; > >> > >>+ smd { > >>+ rpm { > >>+ rpm-requests { > >>+ pm8916-regulators { > >>+ > >>+ vdd_l1_l2_l3-supply = <&pm8916_s3>; > >>+ vdd_l5-supply = <&pm8916_s3>; > >>+ vdd_l4_l5_l6-supply = <&pm8916_s4>; > >>+ vdd_l7-supply = <&pm8916_s4>; > >>+ > >> > > > >If you're nested this deeply, you should consider using labels, e.g. > > > Labels are good and works for me. > > Stephen/Andy are you ok to use labels for such deeply nested nodes in board > dts? I tend to agree with Arnd. I am ok with using labels.