From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751641AbcAMP1i (ORCPT ); Wed, 13 Jan 2016 10:27:38 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:34452 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbcAMP1g (ORCPT ); Wed, 13 Jan 2016 10:27:36 -0500 Date: Wed, 13 Jan 2016 10:27:35 -0500 (EST) Message-Id: <20160113.102735.1851782053420522112.davem@davemloft.net> To: matti.vaittinen@nokia.com Cc: johannes.berg@intel.com, jbenc@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexander.sverdlin@nokia.com, teppo.o.pennanen@nokia.com Subject: Re: [PATCH v2 1/1] net: netlink: Fix multicast group storage allocation for families with more than one groups From: David Miller In-Reply-To: <20160113075400.GA12580@fi-ourus-dhcp00977.emea.nsn-net.net> References: <20160113075400.GA12580@fi-ourus-dhcp00977.emea.nsn-net.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Jan 2016 07:27:36 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matti Vaittinen Date: Wed, 13 Jan 2016 09:54:12 +0200 > Hello again, > > Second version, Fixed the 'off by one' bug spotted by David. > > Br. > Matti Vaittinen > > Multicast groups are stored in global buffer. Check for needed buffer size > incorrectly compares buffer size to first id for family. This means that > for families with more than one mcast id one may allocate too small buffer > and end up writing rest of the groups to some unallocated memory. Fix the > buffer size check to compare allocated space to last mcast id for the > family. > > Tested on ARM using kernel 3.14 > > Signed-off-by: Matti Vaittinen I inadvertantly applied your original patch, so I'll just fix the off-by-one error with a seperate commit. Sorry for the confusion and thanks for fixing this.