From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933050AbcAMJdl (ORCPT ); Wed, 13 Jan 2016 04:33:41 -0500 Received: from verein.lst.de ([213.95.11.211]:41888 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932117AbcAMJdj (ORCPT ); Wed, 13 Jan 2016 04:33:39 -0500 Date: Wed, 13 Jan 2016 10:33:36 +0100 From: Christoph Hellwig To: "Nicholas A. Bellinger" Cc: Christoph Hellwig , "Nicholas A. Bellinger" , target-devel , linux-scsi , lkml , Sagi Grimberg , Hannes Reinecke , Andy Grover , Vasu Dev , Vu Pham Subject: Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function Message-ID: <20160113093336.GB14377@lst.de> References: <1452458668-11034-1-git-send-email-nab@daterainc.com> <1452458668-11034-2-git-send-email-nab@daterainc.com> <20160112151119.GD2058@lst.de> <1452672566.27508.44.camel@haakon3.risingtidesystems.com> <20160113081700.GB12642@lst.de> <1452676969.27508.60.camel@haakon3.risingtidesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452676969.27508.60.camel@haakon3.risingtidesystems.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2016 at 01:22:49AM -0800, Nicholas A. Bellinger wrote: > Huh..? It's used by iscsi-target, ib_isert, tcm_qla2xxx, vhost-scsi and > tcm_fc. > > That's the majority of the drivers people care about. ib_isert never calls transport_init_session / transport_init_session_tags directly. We've got 3 callers to transport_init_session_tags vs 6 to transport_init_session. iSCSI already works roughly the way I suggest everything should work in the future - it uses transport_init_session but manually allocates the tags.