From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755216AbcAMKDe (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jan 2016 05:03:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51622 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750967AbcAMKDc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jan 2016 05:03:32 -0500
Date: Wed, 13 Jan 2016 11:03:28 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable
Message-ID: <20160113100328.GA5515@krava.brq.redhat.com>
References: <1452509693-13452-1-git-send-email-jolsa@kernel.org>
 <1452509693-13452-7-git-send-email-jolsa@kernel.org>
 <5694C73C.3070007@huawei.com>
 <20160113091913.GA4487@krava.brq.redhat.com>
 <56961CE5.8090802@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56961CE5.8090802@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 13, 2016 at 05:46:13PM +0800, Wangnan (F) wrote:

SNIP

> >
> >I'll try to check on that.. does this patch help to improve
> >the current speed or do you need to solve this to get substantial
> >speedup?
> 
> I'm working on it. I have already done it, but still have some
> problem. On some machine 'make_static' test target lost
> '-liberty -lz' in its linker options. Seems something wrong in
> this part:
> 
> ifeq ($(feature-libbfd), 1)
>   EXTLIBS += -lbfd
> 
>   # call all detections now so we get correct
>   # status in VF output
>   $(call feature_check,liberty)
>   $(call feature_check,liberty-z)
>   $(call feature_check,cplus-demangle)
> 
>   ifeq ($(feature-liberty), 1)
>     EXTLIBS += -liberty
>   else
>     ifeq ($(feature-liberty-z), 1)
>       EXTLIBS += -liberty -lz
>     endif
>   endif
> endif

IIRC we had issues with this before.. different systems
provide those libs in different way, like:
  2cf9040714f3 perf tools: Fix bfd dependency libraries detection

you might want to check feature detection code if it gets
built properly on your system

jirka