From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934286AbcAML6I (ORCPT ); Wed, 13 Jan 2016 06:58:08 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51259 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933914AbcAML6G (ORCPT ); Wed, 13 Jan 2016 06:58:06 -0500 Date: Wed, 13 Jan 2016 11:57:36 +0000 From: Mark Brown To: Laxman Dewangan Cc: Krzysztof Kozlowski , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, Mallikarjun Kasoju Message-ID: <20160113115736.GJ6588@sirena.org.uk> References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-7-git-send-email-ldewangan@nvidia.com> <5695A854.60108@samsung.com> <5696378B.6070704@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="y23ShSVTng6i3e6h" Content-Disposition: inline In-Reply-To: <5696378B.6070704@nvidia.com> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for max77620/max20024 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --y23ShSVTng6i3e6h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 13, 2016 at 05:09:55PM +0530, Laxman Dewangan wrote: > Yaah, this is something new and I think Mark also wanted to do this cleanup > on his comment. I did not understand it previously. Looks cool now. I did, please don't just ignore review comments. > However, I have requirement to configure PMIC with some inital setting based > on init_data (parsed) before regulator registration happened. Once I move to > this new mecahinsm, the inti_data parsing and regulator init happen in the > same function. So I need to have one callback from regulator_register to > driver. > Something below. This will do the pre configuration before > regulator_register happena dn machine constraint sets. > I can not use the init_data->regulator_init() as I need to have the init > data passed to the driver. Why do you have this requirement? --y23ShSVTng6i3e6h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWljuvAAoJECTWi3JdVIfQ8wgH/1cr0ePAjPu5Hqbfs3MHF++o yPxHIje7M4w3vA1WPCTVBAYrzy9HAM63VdMNph3w4K82TLArajbY+zzz3VRs9+/+ QUAqyPrMEZ5+r/mg66MPwLVLfyoYvBmv0w93AP64Ik/9a8NmLN4usmzJIdfJAGl1 wcYNQG/V2lTvRcJ/ypUZX3mEVQo34Sb+b5BkBU+ViugQ7jO87aAsvc3dGT0Srpsd iYujuh74ZJZp//936UEKBFj/5m0sG6w0cLZ/o2MVO8Uk1kRQWYJEvomcJte/yEZM oC0V65tUXqBWdKwVEVvQ6jGHzbwQkgTe38GElzbqR/Gbj03RjRkZJWrYSKOEMxY= =nZQW -----END PGP SIGNATURE----- --y23ShSVTng6i3e6h--