From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933011AbcAMNJi (ORCPT ); Wed, 13 Jan 2016 08:09:38 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51510 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932880AbcAMNJg (ORCPT ); Wed, 13 Jan 2016 08:09:36 -0500 Date: Wed, 13 Jan 2016 13:09:09 +0000 From: Mark Brown To: Laxman Dewangan Cc: Krzysztof Kozlowski , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, Mallikarjun Kasoju Message-ID: <20160113130909.GL6588@sirena.org.uk> References: <1452590273-16421-1-git-send-email-ldewangan@nvidia.com> <1452590273-16421-7-git-send-email-ldewangan@nvidia.com> <5695A854.60108@samsung.com> <5696378B.6070704@nvidia.com> <20160113115736.GJ6588@sirena.org.uk> <56963D8D.9060908@nvidia.com> <20160113123133.GK6588@sirena.org.uk> <5696451F.3000707@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GWLvvOwKrQC9aCO6" Content-Disposition: inline In-Reply-To: <5696451F.3000707@nvidia.com> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for max77620/max20024 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GWLvvOwKrQC9aCO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 13, 2016 at 06:07:51PM +0530, Laxman Dewangan wrote: > On Wednesday 13 January 2016 06:01 PM, Mark Brown wrote: > >What is FPS_SRC and why is it set from init_data? A driver should never > >be looking at init_data. > When FPS_SRC is set to NONE (this is needed from platform data) then based > on constraint like boot enable/always enable, it need to be on desired > state. Otherwise we may endup with disabling the rail when setting to NONE > and create issue. What is "it" and why can't we check what the current configuration is while setting FPS to NONE? > I need to set the FPS src properly for each rails before callback happen > from regulator init so that enable/disable/is_enable can handle it properly. Why not just reorder the callback so it happens before the constraints are applied? --GWLvvOwKrQC9aCO6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWlkx0AAoJECTWi3JdVIfQH50H/2fuJLY76kSR7ePDsn6wPrIE 5srOQ0u5g8LLfdwt21pyjUHao8j/npEfiXpgYr6chcezHqYYtP5CEC7UDud8rmUa CHmGucFHTytYS7W0d8XNdbONIcxUOtXN2Bui+SYvpONb2OUFe8elh8TW/hmz/NIo iiWkRrnFLUc+Uf7dZw9RMsu0NXBU2VXqeCY1BN1fY7Sif/eWBf+YP4mpEdFj5l9+ ebmdPCrILWRDrzsEUrCuo0o2+saJaIWzGHv7gwOBu02Dh07zPVr+57fuAHdiBQmn worPox87muri8Rq5sSENdP9mMa4dOsBf9FuZTNsVFRWVH6BkyFDNWsBvz4f1Cwo= =MLnx -----END PGP SIGNATURE----- --GWLvvOwKrQC9aCO6--