From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760659AbcAMNbJ (ORCPT ); Wed, 13 Jan 2016 08:31:09 -0500 Received: from mx2.suse.de ([195.135.220.15]:56608 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758514AbcAMNbH (ORCPT ); Wed, 13 Jan 2016 08:31:07 -0500 Date: Wed, 13 Jan 2016 14:31:02 +0100 From: David Sterba To: Dan Carpenter Cc: Chris Mason , Liu Bo , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] Btrfs: clean up an error code in btrfs_init_space_info() Message-ID: <20160113133102.GQ4227@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Dan Carpenter , Chris Mason , Liu Bo , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20160113122117.GB19993@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160113122117.GB19993@mwanda> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2016 at 03:21:17PM +0300, Dan Carpenter wrote: > If we return 1 here, then the caller treats it as an error and returns > -EINVAL. It causes a static checker warning to treat positive returns > as an error. > > Fixes: 1aba86d67f34 ('Btrfs: fix easily get into ENOSPC in mixed case') > Signed-off-by: Dan Carpenter > --- > I would appreciate a little review here. This patch doesn't change > behavior, but it's possible that we had intended to do something else. No, it makes sense to switch it to -EINVAL. Thanks. Reviewed-by: David Sterba