From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754364AbcAMWtT (ORCPT ); Wed, 13 Jan 2016 17:49:19 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:55483 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338AbcAMWtR (ORCPT ); Wed, 13 Jan 2016 17:49:17 -0500 Date: Wed, 13 Jan 2016 14:49:16 -0800 From: Andrew Morton To: Johannes Weiner Cc: Michal Hocko , Vladimir Davydov , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/2] mm: memcontrol: cgroup2 memory statistics Message-Id: <20160113144916.03f03766e201b6b04a8a47cc@linux-foundation.org> In-Reply-To: <1452722469-24704-1-git-send-email-hannes@cmpxchg.org> References: <1452722469-24704-1-git-send-email-hannes@cmpxchg.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jan 2016 17:01:07 -0500 Johannes Weiner wrote: > Hi Andrew, > > these patches add basic memory statistics so that new users of cgroup2 > have some inkling of what's going on, and are not just confronted with > a single number of bytes used. > > This is very short-notice, but also straight-forward. It would be cool > to get this in along with the lifting of the cgroup2 devel flag. > > Michal, Vladimir, what do you think? We'll also have to figure out how > we're going to represent and break down the "kmem" consumers. > It would be nice to see example output, and a description of why this output was chosen: what was included, what was omitted, why it was presented this way, what units were chosen for displaying the stats and why. Will the things which are being displayed still be relevant (or even available) 10 years from now. etcetera. And the interface should be documented at some point. Doing it now will help with the review of the proposed interface. Because this stuff is forever and we have to get it right.