From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750821AbcANFtL (ORCPT ); Thu, 14 Jan 2016 00:49:11 -0500 Received: from mail-by2on0073.outbound.protection.outlook.com ([207.46.100.73]:19808 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750710AbcANFtH (ORCPT ); Thu, 14 Jan 2016 00:49:07 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O0XHHN-08-KAT-02 X-M-MSG: Date: Thu, 14 Jan 2016 13:48:24 +0800 From: Huang Rui To: Dan Carpenter CC: Thomas Gleixner , Yinghai Lu , Ingo Molnar , "H. Peter Anvin" , , Borislav Petkov , Aravind Gopalakrishnan , Andy Lutomirski , "Hector Marco-Gisbert" , , Subject: Re: [patch] x86/AMD: remove an unneeded condition in srat_detect_node() Message-ID: <20160114054823.GB4638@hr-amur2> References: <20160113123940.GE19993@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160113123940.GE19993@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2970300002)(428002)(189002)(199003)(24454002)(23726003)(92566002)(4001350100001)(33716001)(2906002)(97736004)(106466001)(5008740100001)(586003)(4326007)(1096002)(1076002)(1220700001)(46406003)(50986999)(19580405001)(189998001)(2950100001)(83506001)(47776003)(33656002)(105586002)(110136002)(19580395003)(97756001)(86362001)(77096005)(54356999)(11100500001)(101416001)(50466002)(76176999)(87936001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0716;H:atltwp02.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:3;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;2:vZxYegua972GGeUTz2qMm9KBRrs5T6cYvi25pravw3pZHS5tsnkIoM2WWX9Rckj0gr0BSY18/Jxi3FsiK/3BJ1vuev9td8vRNYIXKEEQc/VaUmGMFOtqeEuicRY2QH6MB1PDckzhlRyAPwm5Ymwk3Q==;3:PImkbmlCdm+Kp30L2Gsgp6Iq0AmpZmQQQZJ+UGrFSHtiLkNyGf2QHFM5MUhzchv78oO8wNyIPrXke1tX//P4B/TTmhrnM0Rhg1RxP1hwowHGfaYWlcyiPubof6uStya215tE+NuELG6bTA17kHx5YmKLh6UTO+PhVbaXHVuo2Lulkdzs4OPOaU3HbCNTX/JbYTMojXlfC2LY6+6ftpBwg9QKbsv0PF7GBkMiCnJWkk8=;25:aTj6QY02Vp1vsVT+o5jr/DRHdCE9DIYv7G0mO+Vp0a4DuBYY0joRGiA7rpuNzjkUAhCATWCbXPYr+Bhu9U3Mbgogir1NSeU5bKS4AeFj+pi4BSX8X0KPgGW4EqPnMH1wqvnDD1X7era7AUQNV6IDlpJlqMMauUQi714BXgGpRbt4vTkFX9xPmh2FWwrtdsmkBDE8u0KqvcfqhHyMkDGBDu98rnYfY8KXKigPhcjo9dZN7pAlNxxVnf9Vqqb/qQuD X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0716; X-MS-Office365-Filtering-Correlation-Id: 4efc9530-5ba2-4fe3-2de6-08d31ca667f2 X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;20:JkQECaegwuBszFJJVaS5sSFZtWjFAI1zzYfSTgmLWfdlIK2u14X5CZ0I7JKTiPUKO+yXVuFVrAUuKKNKie4J6rNdGzn/RZM4V7pn387uAzEoDqs0klJDOQYvJFAgtMSDvq+6NAMOSi0/3NpsBzpgfmU3odvR2ZddLv8IaENkmow5FxG0GPvxsLjJwsmrboqbB+1RnVkd0D88gQWYT6tn7JfsOxc3K/wy3y7y2WRjwoI+yXDaABOdkK4dMk504o0PE8F9xdifH8FN7ZcTOn6QORhj/Df/aohL0MI+k8RuSDwbNwdQxPJqaCw004QnoUFpWoCapEz/8eF9v1bVWqqWTSB7I3d/DH5f/7rMF0BJeINigpmXZUdf7vDWzqMjDQbBUVDS39iPPHhxuI/jisbe/oLLiuTljyRJHrg65gOJPWmK73DqTuzE1vwctsgA7SxfYjHy5Bp0C+/xN6oqWy8SEG+3Epzf5GMKCGRVtEZe9O9qEzitwkysWUGjFFSgB5J6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(13018025)(8121501046)(13017025)(13015025)(3002001)(10201501046);SRVR:CY1PR12MB0716;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0716; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;4:1lvv5lkrIFUBIFkbTWhPMjica6IkIEZ8VxQSsm7YAwy3rLuwZnYrCeePO40TQ1fF7hHZ9mNL+VdwzygCTvgWBYft/7mY1+xyochnREyRRmn9zIXXCzxXZt3OuJGogcBSsV0jSAsIXxH8PqfGAup97uD6JUE9zL+HXV6GqoJq8cwmO2z0lgikxLo0WZzAGEgFgj3azK47PegP5N4FTAywYXuMGJerdiUpMOSdAs/1r3BnzFl26rwkJfVpavF1jJ5cSgmnQaPyNw+ilgTAVZZ70tKKCI3ROK2VNNiF8giqU/b2imTScdn9MOi7Z4Xmbla0JUbnkDLbCrq2M3LZtzZpBdUmv9Z5fX6thxlAB2/WP4/3r+bGF7QTbrKLkSBDgLGPo4L4o4boCPwxcw+2XjVg1VDbH2e4aK0xBE8OYg2zDIetZm6cYQdumXSjyQprI21vAkeDSger+8dvsfobGyHWgSTJG3r78Q/G/UieHb2xqYY= X-Forefront-PRVS: 08213D42D3 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR12MB0716;23:EhzL66YJrAQJoK+ITKJs5ME40slzq6l5fENNXMP/4?= =?us-ascii?Q?xNwbpXq8mpJY7S0EHH3aBP7EYwwGRDIHY0d4WHOX+DcUc3T+e7lzuZMLyIt+?= =?us-ascii?Q?M0ySh7Igte0gm2OKT2SBc10f5OgW4fu/z59wKKN+l9U/bn3xJpZsFOvIOpEW?= =?us-ascii?Q?jD46d8CW+0lmprQo+lNnnw/t2Ml1FziMfayrzGUFAamiG+OhROaRBGdtgycZ?= =?us-ascii?Q?vibF9zheEo7vedbrYucH7rCl1Zk+az9b2MrBDmnJfFmKWFiyyXJ/9an4Ebpu?= =?us-ascii?Q?vbYe2zP5DoDYKvxBb4U7tY4+txOXwoGMMGiHX/4ZDKqjHyCaADZri5G+NPw0?= =?us-ascii?Q?pTM9nd4zK48ho2kGkInKbnGbXGWcsTVHAN05j9HFTjsrLhW8rbOt/ew3E6XP?= =?us-ascii?Q?c/uWqzPm1SN7cnPbVpbOGpxnd7piXSl4n/LFEPsrx+gyA78Gg99kJXirXqrZ?= =?us-ascii?Q?jW6CgN1SuhFfEMVHyuYSPcBtXBiWPCZUBvVOhoF4GxtK3jTlhDf/m4xUBaCK?= =?us-ascii?Q?imtbIOcugISRdRNxmq6t2LyOxjq/77+tQxq+cEPUqVzH21ZDvio45f/6XBIH?= =?us-ascii?Q?83OlbPIHg+lExXyYGeyYDmvlI5Qv9Pk2kXl1ieoNORdyv12xOnfy6R3Wc0Sr?= =?us-ascii?Q?9dTUbhwAVpvlfKBPM6JEFonyEa2dZEZiU9McDIbbuuIond0myaAXKPZLIfBo?= =?us-ascii?Q?BR0HzQtluISnlQXX42gpEnp6vgmzll9Ljv4KhW0QW1RiZ3GdCVhQDQLKTap4?= =?us-ascii?Q?q5M6A75tVmCXE0YNuI4wY9u2+4Vy07GFLUzrtRTm6AM+AsBwkRB4rziUEf1E?= =?us-ascii?Q?7VHVm++i6hDxKXqiR8dVGHT9GhQezxkL1ozP9Vjqipd1dd42kLaTg5Q/7oqm?= =?us-ascii?Q?e3Ukf+Y+RoXjspgAmCCGandeMVudvPxAoGby7g8nHnOJfmQr9YPCP275oBKS?= =?us-ascii?Q?PoTSC5Yq7JoEo5jX6QJjDAW10N+J8j7Zo9ZzcBxuDW2Fx76H3nmITPPmFXA9?= =?us-ascii?Q?JxtPM/r35o5zou3Y5c9OjSCMVH5/6h1aCHL3Yz5YMpmljCXgItZO5KkQmhsz?= =?us-ascii?Q?nZD8v4=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0716;5:pi24ChT+NlA7b69QmKvWLbRhQTEeK2mclNZm+YlgbgFbSGeovBf56olZqFGS6q9N6BCLuqGSSuNYeBtzv6uJuNZC4cKd38PGc3792rXnSgr4nVrrTavZIWD6xHFoGUaMlY7mNetfvGRhptJ+M+VicQ==;24:tSOYT3WHCWZ1GcUhrjGezP5SZe48dLPYShbvjM/NsWYGI0GSU0qb3h8lzDvwZLl8GgZkhvIcu5mJfKv3lv43XQzvLRVrh7KxEnfSN6l2cj8=;20:jWKVLBRF/cNylclcgJhCd0ZpPnp02Bufj+CWZRGycxi/RFyXijuCsxtoeQ5SjPjr8dfHw0489Wjk8z9DHJqi6xDYM85xpOC/YvzARODDKNp6ljCRGX2qT4H0cTnhctxUHoHdWXjauEEqDLJVMNr9ak5+pql3stVw87PVqYzjVIW4uGabtY/LM28LRE1kJkFHKKhBhD8HEcwQcAHuFpvFOHB8e9YNaXIlZssJ4Bz/77u0iI+emBsrsVX3cT+GFkFj SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2016 05:49:01.3913 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0716 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2016 at 03:39:40PM +0300, Dan Carpenter wrote: > Originally we calculated ht_nodeid as "ht_nodeid = apicid - boot_cpu_id;" > so presumably it could be negative. But after commit 01aaea1afbcd > ('x86: introduce initial apicid') we use c->initial_apicid which is an > unsigned short and thus always >= 0. > > It causes a static checker warning to test for impossible conditions so > let's remove it. > > Signed-off-by: Dan Carpenter > Looks OK for me. Reviewed-by: Huang Rui > diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c > index e678dde..a07956a 100644 > --- a/arch/x86/kernel/cpu/amd.c > +++ b/arch/x86/kernel/cpu/amd.c > @@ -434,8 +434,7 @@ static void srat_detect_node(struct cpuinfo_x86 *c) > */ > int ht_nodeid = c->initial_apicid; > > - if (ht_nodeid >= 0 && > - __apicid_to_node[ht_nodeid] != NUMA_NO_NODE) > + if (__apicid_to_node[ht_nodeid] != NUMA_NO_NODE) > node = __apicid_to_node[ht_nodeid]; > /* Pick a nearby node */ > if (!node_online(node))