From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753130AbcANJ4k (ORCPT ); Thu, 14 Jan 2016 04:56:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44690 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbcANJ4i (ORCPT ); Thu, 14 Jan 2016 04:56:38 -0500 Date: Thu, 14 Jan 2016 10:56:35 +0100 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com, lizefan@huawei.com, Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim Subject: Re: [PATCH 3/9] perf build: Test correct path of perf in build-test Message-ID: <20160114095635.GA31454@krava.brq.redhat.com> References: <1452687442-6186-1-git-send-email-wangnan0@huawei.com> <1452687442-6186-4-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452687442-6186-4-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2016 at 12:17:16PM +0000, Wang Nan wrote: > If an 'O' is passed to 'make build-test', many 'test -x' and 'test -f' > will fail because perf resides in a different directory. Fix this by > computing PERF_OUT according to 'O' and test correct output files. > For make_kernelsrc and make_kernelsrc_tools, set KBUILD_OUTPUT_DIR > instead because the path is different from others ($(O)/perf vs > $(O)/tools/perf). > > Signed-off-by: Wang Nan > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Namhyung Kim > --- > tools/perf/tests/make | 23 +++++++++++++++-------- > 1 file changed, 15 insertions(+), 8 deletions(-) > > diff --git a/tools/perf/tests/make b/tools/perf/tests/make > index 14d7b8d..1e59ce8 100644 > --- a/tools/perf/tests/make > +++ b/tools/perf/tests/make > @@ -13,10 +13,12 @@ else > endif > else > PERF := . > +PERF_OUT := $(PERF) > O_OPT := given that we use _O suffix everywhere in here, would PERF_O suit better? thanks, jirka