From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753213AbcANJ5T (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jan 2016 04:57:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39677 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753168AbcANJ5R (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jan 2016 04:57:17 -0500
Date: Thu, 14 Jan 2016 10:57:13 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com,
        lizefan@huawei.com, Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 3/9] perf build: Test correct path of perf in build-test
Message-ID: <20160114095713.GB31454@krava.brq.redhat.com>
References: <1452687442-6186-1-git-send-email-wangnan0@huawei.com>
 <1452687442-6186-4-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1452687442-6186-4-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 13, 2016 at 12:17:16PM +0000, Wang Nan wrote:

SNIP

> +test_make_python_perf_so := test -f $(PERF_OUT)/python/perf.so
>  
> -test_make_perf_o           := test -f $(PERF)/perf.o
> -test_make_util_map_o       := test -f $(PERF)/util/map.o
> -test_make_util_pmu_bison_o := test -f $(PERF)/util/pmu-bison.o
> +test_make_perf_o           := test -f $(PERF_OUT)/perf.o
> +test_make_util_map_o       := test -f $(PERF_OUT)/util/map.o
> +test_make_util_pmu_bison_o := test -f $(PERF_OUT)/util/pmu-bison.o
>  
>  define test_dest_files
>    for file in $(1); do				\
> @@ -244,7 +246,7 @@ test_make_perf_o_O            := test -f $$TMP_O/perf.o
>  test_make_util_map_o_O        := test -f $$TMP_O/util/map.o
>  test_make_util_pmu_bison_o_O := test -f $$TMP_O/util/pmu-bison.o
>  
> -test_default = test -x $(PERF)/perf
> +test_default = test -x $(PERF_OUT)/perf
>  test = $(if $(test_$1),$(test_$1),$(test_default))
>  
>  test_default_O = test -x $$TMP_O/perf
> @@ -264,7 +266,7 @@ endif
>  
>  MAKEFLAGS := --no-print-directory
>  
> -clean := @(cd $(PERF); make -s -f $(MK) clean >/dev/null)
> +clean := @(cd $(PERF); make -s -f $(MK) O=$(PERF_OUT) clean >/dev/null; make -s -f $(MK) clean >/dev/null)

what's the second make clean for?

thanks,
jirka